From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Asif Rehman <asifr.rehman@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: Allow CURRENT_ROLE in GRANTED BY
Date: Thu, 10 Sep 2020 18:21:54 +0200
Message-ID: <7352ff27-72b9-254d-a745-74ea983440fa@2ndquadrant.com> (raw)
In-Reply-To: <159947296972.1157.15288153297863434487.pgcf@coridan.postgresql.org>
References: <f2feac44-b4c5-f38f-3699-2851d6a76dc9@2ndquadrant.com>
<cc12f3fc-9fb1-71dc-1b51-1edf65f9e5c2@2ndquadrant.com>
<159947296972.1157.15288153297863434487.pgcf@coridan.postgresql.org>
On 2020-09-07 12:02, Asif Rehman wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> The patch applies cleanly and looks fine to me. However wouldn't it be better to just map the CURRENT_ROLE to CURRENT_USER in backend grammar?
Existing code treats them differently. I think, given that the code is
already written, it is good to preserve what the user wrote.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, asifr.rehman@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Allow CURRENT_ROLE in GRANTED BY
In-Reply-To: <7352ff27-72b9-254d-a745-74ea983440fa@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox