From: Chao Li <li.evan.chao@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: ji xu <thanksgreed@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Fix bug of clearing of waitStart in ProcWakeup()
Date: Thu, 26 Feb 2026 09:04:01 +0800
Message-ID: <73B94181-ED28-4BFD-9FF4-20D236DCEBA4@gmail.com> (raw)
In-Reply-To: <CAHGQGwEZJ-vo0gW0=kjbag2-UMk6j_qt58JV4x05f=kB5OrT1g@mail.gmail.com>
References: <537BD852-EC61-4D25-AB55-BE8BE46D07D7@gmail.com>
<CANWi6YNc+qC7O086svzf1jO=udJNA8+aa0gqp2BS7tyKB7dLaA@mail.gmail.com>
<CAHGQGwHJGgZS8iiJVUse1QraMXmYzo+5vw4jd-0MQe5h9pyWXg@mail.gmail.com>
<2058F900-0706-4B46-A398-54FDABFD29F7@gmail.com>
<CAHGQGwEZJ-vo0gW0=kjbag2-UMk6j_qt58JV4x05f=kB5OrT1g@mail.gmail.com>
> On Feb 26, 2026, at 08:08, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Wed, Feb 25, 2026 at 7:03 AM Chao Li <li.evan.chao@gmail.com> wrote:
>>
>>
>>
>>> On Feb 24, 2026, at 23:41, Fujii Masao <masao.fujii@gmail.com> wrote:
>>>
>>> On Tue, Feb 24, 2026 at 4:31 PM ji xu <thanksgreed@gmail.com> wrote:
>>>>
>>>>
>>>> Chao Li <li.evan.chao@gmail.com> 于2026年2月24日周二 14:29写道：
>>>>>
>>>>> Since this function is clearly operating on the parameter proc, the only statement that touches MyProc looks suspicious. It should reset proc->waitStart, not MyProc->waitStart.
>>>>>
>>>>> As written, it will incorrectly clear the caller’s waitStart instead of the awakened backend’s, potentially leaving a stale waitStart value in the target PGPROC.
>>>
>>> Thanks for the report!
>>>
>>
>> I just realized that I forgot to attach the patch file. Anyway, that’s just a one-line change.
>
> I've pushed the patch. Thanks!
>
> Regards,
>
> --
> Fujii Masao
Hi Fujii-san, thank you very much for taking care of this patch.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: li.evan.chao@gmail.com, masao.fujii@gmail.com, thanksgreed@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Fix bug of clearing of waitStart in ProcWakeup()
In-Reply-To: <73B94181-ED28-4BFD-9FF4-20D236DCEBA4@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox