public inbox for [email protected]  

help / color / mirror / Atom feed

From: Chao Li <[email protected]>
To: Peter Smith <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Add missing period to DETAIL messages
Date: Thu, 9 Apr 2026 16:00:10 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHut+PszSntkUgN+Qa9matGY6MLEoFGSuVbuKDgnnTdZ7YPRwg@mail.gmail.com>
References: <CAHut+PszSntkUgN+Qa9matGY6MLEoFGSuVbuKDgnnTdZ7YPRwg@mail.gmail.com>



> On Apr 9, 2026, at 12:27, Peter Smith <[email protected]> wrote:
> 
> Hi,
> 
> According to the error message style guide [1] "Detail and hint
> messages: Use complete sentences, and end each with a period."
> 
> I found some DETAIL messages not following that period rule.
> 
> PSA a patch that fixes the missing period. In passing, I also fixed
> some capitalization.
> 
> ======
> [1] https://www.postgresql.org/docs/devel/error-style-guide.html#ERROR-STYLE-GUIDE-GRAMMAR-PUNCTUATION
> 
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
> <v1-0001-Add-missing-period-to-DETAIL-messages.patch>


```
-					 errdetail("password must be at least \"passwordcheck.min_password_length\" (%d) bytes long",
+					 errdetail("password must be at least \"passwordcheck.min_password_length\" (%d) bytes long.”,
```

First “p” should be capital.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Add missing period to DETAIL messages
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox