From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: daniel@yesql.se <daniel@yesql.se>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: michael@paquier.xyz <michael@paquier.xyz>
Subject: Re: Preventing abort() and exit() calls in libpq
Date: Thu, 01 Jul 2021 14:14:24 -0400
Message-ID: <745046.1625163264@sss.pgh.pa.us> (raw)
In-Reply-To: <9d35a4ac-2c75-cb44-95ab-61d69deb072e@enterprisedb.com>
References: <3128896.1624742969@sss.pgh.pa.us>
<18eda75d-af6d-3fc0-03b6-607eff9f392a@enterprisedb.com>
<622907.1625084114@sss.pgh.pa.us>
<630837.1625092151@sss.pgh.pa.us>
<67ddcb26f82acaffb26c59b7d8e4cd75399b2cd3.camel@vmware.com>
<9d35a4ac-2c75-cb44-95ab-61d69deb072e@enterprisedb.com>
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 01.07.21 00:41, Jacob Champion wrote:
>> Spitballing -- if you don't like the stamp file, you could add the
>> check to the end of the $(shlib) rule, surrounded by an ifeq check.
>> Then .DELETE_ON_ERROR should take care of the rest, I think.
> Somewhere in the $(shlib) rule would seem most appropriate. But I don't
> understand the rest: What ifeq, and why .DELETE_ON_ERROR?
The variant of this I'd been thinking of was
$(shlib): $(OBJS) | $(SHLIB_PREREQS)
$(LINK.shared) -o $@ $(OBJS) $(LDFLAGS) $(LDFLAGS_SL) $(SHLIB_LINK)
+ifneq (,$(SHLIB_EXTRA_ACTION))
+ $(SHLIB_EXTRA_ACTION)
+endif
(and similarly in several other places); then libpq's Makefile
could set SHLIB_EXTRA_ACTION to the desired thing.
The problem then is, what happens when the extra action fails?
Without .DELETE_ON_ERROR, the shlib is still there and the next
make run will think everything's good.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pchampion@vmware.com, daniel@yesql.se, michael@paquier.xyz
Subject: Re: Preventing abort() and exit() calls in libpq
In-Reply-To: <745046.1625163264@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox