public inbox for [email protected]
help / color / mirror / Atom feed[PATCH v48 5/7] Doc part of shared-memory based stats collector.
6+ messages / 4 participants
[nested] [flat]
* [PATCH v48 5/7] Doc part of shared-memory based stats collector.
@ 2020-03-19 06:11 Kyotaro Horiguchi <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Kyotaro Horiguchi @ 2020-03-19 06:11 UTC (permalink / raw)
---
doc/src/sgml/catalogs.sgml | 6 +-
doc/src/sgml/config.sgml | 27 +++---
doc/src/sgml/high-availability.sgml | 13 +--
doc/src/sgml/monitoring.sgml | 127 +++++++++++++---------------
doc/src/sgml/ref/pg_dump.sgml | 9 +-
5 files changed, 86 insertions(+), 96 deletions(-)
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index b1de6d0674..0ef684d4d0 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -9261,9 +9261,9 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l
<para>
<xref linkend="view-table"/> lists the system views described here.
More detailed documentation of each view follows below.
- There are some additional views that provide access to the results of
- the statistics collector; they are described in <xref
- linkend="monitoring-stats-views-table"/>.
+ There are some additional views that provide access to the activity
+ statistics; they are described in
+ <xref linkend="monitoring-stats-views-table"/>.
</para>
<para>
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 967de73596..753b1ab6f9 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -7375,11 +7375,11 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
<title>Run-time Statistics</title>
<sect2 id="runtime-config-statistics-collector">
- <title>Query and Index Statistics Collector</title>
+ <title>Query and Index Activity Statistics</title>
<para>
- These parameters control server-wide statistics collection features.
- When statistics collection is enabled, the data that is produced can be
+ These parameters control server-wide activity statistics features.
+ When activity statistics is enabled, the data that is produced can be
accessed via the <structname>pg_stat</structname> and
<structname>pg_statio</structname> family of system views.
Refer to <xref linkend="monitoring"/> for more information.
@@ -7395,14 +7395,13 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
</term>
<listitem>
<para>
- Enables the collection of information on the currently
- executing command of each session, along with the time when
- that command began execution. This parameter is on by
- default. Note that even when enabled, this information is not
- visible to all users, only to superusers and the user owning
- the session being reported on, so it should not represent a
- security risk.
- Only superusers can change this setting.
+ Enables activity tracking on the currently executing command of
+ each session, along with the time when that command began
+ execution. This parameter is on by default. Note that even when
+ enabled, this information is not visible to all users, only to
+ superusers and the user owning the session being reported on, so it
+ should not represent a security risk. Only superusers can change this
+ setting.
</para>
</listitem>
</varlistentry>
@@ -7433,9 +7432,9 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
</term>
<listitem>
<para>
- Enables collection of statistics on database activity.
+ Enables tracking of database activity.
This parameter is on by default, because the autovacuum
- daemon needs the collected information.
+ daemon needs the activity information.
Only superusers can change this setting.
</para>
</listitem>
@@ -8533,7 +8532,7 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
<listitem>
<para>
Specifies the fraction of the total number of heap tuples counted in
- the previous statistics collection that can be inserted without
+ the previously collected statistics that can be inserted without
incurring an index scan at the <command>VACUUM</command> cleanup stage.
This setting currently applies to B-tree indexes only.
</para>
diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index f49f5c0108..45095857eb 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -2217,12 +2217,13 @@ HINT: You can then restart the server after making the necessary configuration
</para>
<para>
- The statistics collector is active during recovery. All scans, reads, blocks,
- index usage, etc., will be recorded normally on the standby. Replayed
- actions will not duplicate their effects on primary, so replaying an
- insert will not increment the Inserts column of pg_stat_user_tables.
- The stats file is deleted at the start of recovery, so stats from primary
- and standby will differ; this is considered a feature, not a bug.
+ The activity statistics is collected during recovery. All scans, reads,
+ blocks, index usage, etc., will be recorded normally on the
+ standby. Replayed actions will not duplicate their effects on primary, so
+ replaying an insert will not increment the Inserts column of
+ pg_stat_user_tables. The activity statistics is reset at the start of
+ recovery, so stats from primary and standby will differ; this is
+ considered a feature, not a bug.
</para>
<para>
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 3513e127b7..a2dad90c91 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -22,7 +22,7 @@
<para>
Several tools are available for monitoring database activity and
analyzing performance. Most of this chapter is devoted to describing
- <productname>PostgreSQL</productname>'s statistics collector,
+ <productname>PostgreSQL</productname>'s activity statistics,
but one should not neglect regular Unix monitoring programs such as
<command>ps</command>, <command>top</command>, <command>iostat</command>, and <command>vmstat</command>.
Also, once one has identified a
@@ -53,7 +53,6 @@ postgres 15554 0.0 0.0 57536 1184 ? Ss 18:02 0:00 postgres: back
postgres 15555 0.0 0.0 57536 916 ? Ss 18:02 0:00 postgres: checkpointer
postgres 15556 0.0 0.0 57536 916 ? Ss 18:02 0:00 postgres: walwriter
postgres 15557 0.0 0.0 58504 2244 ? Ss 18:02 0:00 postgres: autovacuum launcher
-postgres 15558 0.0 0.0 17512 1068 ? Ss 18:02 0:00 postgres: stats collector
postgres 15582 0.0 0.0 58772 3080 ? Ss 18:04 0:00 postgres: joe runbug 127.0.0.1 idle
postgres 15606 0.0 0.0 58772 3052 ? Ss 18:07 0:00 postgres: tgl regression [local] SELECT waiting
postgres 15610 0.0 0.0 58772 3056 ? Ss 18:07 0:00 postgres: tgl regression [local] idle in transaction
@@ -65,9 +64,8 @@ postgres 15610 0.0 0.0 58772 3056 ? Ss 18:07 0:00 postgres: tgl
primary server process. The command arguments
shown for it are the same ones used when it was launched. The next five
processes are background worker processes automatically launched by the
- primary process. (The <quote>stats collector</quote> process will not be present
- if you have set the system not to start the statistics collector; likewise
- the <quote>autovacuum launcher</quote> process can be disabled.)
+ primary process. (The <quote>autovacuum launcher</quote> process will not
+ be present if you have set the system not to start it.)
Each of the remaining
processes is a server process handling one client connection. Each such
process sets its command line display in the form
@@ -130,20 +128,21 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
</sect1>
<sect1 id="monitoring-stats">
- <title>The Statistics Collector</title>
+ <title>The Activity Statistics</title>
<indexterm zone="monitoring-stats">
<primary>statistics</primary>
</indexterm>
<para>
- <productname>PostgreSQL</productname>'s <firstterm>statistics collector</firstterm>
- is a subsystem that supports collection and reporting of information about
- server activity. Presently, the collector can count accesses to tables
- and indexes in both disk-block and individual-row terms. It also tracks
- the total number of rows in each table, and information about vacuum and
- analyze actions for each table. It can also count calls to user-defined
- functions and the total time spent in each one.
+ <productname>PostgreSQL</productname>'s <firstterm>activity
+ statistics</firstterm> is a subsystem that supports tracking and reporting
+ of information about server activity. Presently, the activity statistics
+ tracks the count of accesses to tables and indexes in both disk-block and
+ individual-row terms. It also tracks the total number of rows in each
+ table, and information about vacuum and analyze actions for each table. It
+ can also track calls to user-defined functions and the total time spent in
+ each one.
</para>
<para>
@@ -151,15 +150,15 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
information about exactly what is going on in the system right now, such as
the exact command currently being executed by other server processes, and
which other connections exist in the system. This facility is independent
- of the collector process.
+ of the activity statistics.
</para>
<sect2 id="monitoring-stats-setup">
- <title>Statistics Collection Configuration</title>
+ <title>Activity Statistics Configuration</title>
<para>
- Since collection of statistics adds some overhead to query execution,
- the system can be configured to collect or not collect information.
+ Since tracking for the activity statistics adds some overhead to query
+ execution, the system can be configured to track or not track activity.
This is controlled by configuration parameters that are normally set in
<filename>postgresql.conf</filename>. (See <xref linkend="runtime-config"/> for
details about setting configuration parameters.)
@@ -172,7 +171,7 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
<para>
The parameter <xref linkend="guc-track-counts"/> controls whether
- statistics are collected about table and index accesses.
+ to track activity about table and index accesses.
</para>
<para>
@@ -196,18 +195,11 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
</para>
<para>
- The statistics collector transmits the collected information to other
- <productname>PostgreSQL</productname> processes through temporary files.
- These files are stored in the directory named by the
- <xref linkend="guc-stats-temp-directory"/> parameter,
- <filename>pg_stat_tmp</filename> by default.
- For better performance, <varname>stats_temp_directory</varname> can be
- pointed at a RAM-based file system, decreasing physical I/O requirements.
- When the server shuts down cleanly, a permanent copy of the statistics
- data is stored in the <filename>pg_stat</filename> subdirectory, so that
- statistics can be retained across server restarts. When recovery is
- performed at server start (e.g., after immediate shutdown, server crash,
- and point-in-time recovery), all statistics counters are reset.
+ down cleanly, a permanent copy of the statistics data is stored in
+ the <filename>pg_stat</filename> subdirectory, so that statistics can be
+ retained across server restarts. When recovery is performed at server
+ start (e.g. after immediate shutdown, server crash, and point-in-time
+ recovery), all statistics counters are reset.
</para>
</sect2>
@@ -220,48 +212,46 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
linkend="monitoring-stats-dynamic-views-table"/>, are available to show
the current state of the system. There are also several other
views, listed in <xref
- linkend="monitoring-stats-views-table"/>, available to show the results
- of statistics collection. Alternatively, one can
- build custom views using the underlying statistics functions, as discussed
- in <xref linkend="monitoring-stats-functions"/>.
+ linkend="monitoring-stats-views-table"/>, available to show the activity
+ statistics. Alternatively, one can build custom views using the underlying
+ statistics functions, as discussed in
+ <xref linkend="monitoring-stats-functions"/>.
</para>
<para>
- When using the statistics to monitor collected data, it is important
- to realize that the information does not update instantaneously.
- Each individual server process transmits new statistical counts to
- the collector just before going idle; so a query or transaction still in
- progress does not affect the displayed totals. Also, the collector itself
- emits a new report at most once per <varname>PGSTAT_STAT_INTERVAL</varname>
- milliseconds (500 ms unless altered while building the server). So the
- displayed information lags behind actual activity. However, current-query
- information collected by <varname>track_activities</varname> is
- always up-to-date.
+ When using the activity statistics, it is important to realize that the
+ information does not update instantaneously. Each individual server writes
+ out new statistical counts just before going idle, not frequent than once
+ per <varname>PGSTAT_STAT_INTERVAL</varname> milliseconds (1 second unless
+ altered while building the server); so a query or transaction still in
+ progress does not affect the displayed totals. However, current-query
+ information tracked by <varname>track_activities</varname> is always
+ up-to-date.
</para>
<para>
Another important point is that when a server process is asked to display
- any of these statistics, it first fetches the most recent report emitted by
- the collector process and then continues to use this snapshot for all
- statistical views and functions until the end of its current transaction.
- So the statistics will show static information as long as you continue the
- current transaction. Similarly, information about the current queries of
- all sessions is collected when any such information is first requested
- within a transaction, and the same information will be displayed throughout
- the transaction.
- This is a feature, not a bug, because it allows you to perform several
- queries on the statistics and correlate the results without worrying that
- the numbers are changing underneath you. But if you want to see new
- results with each query, be sure to do the queries outside any transaction
- block. Alternatively, you can invoke
+ any of these statistics, it first reads the current statistics and then
+ continues to use this snapshot for all statistical views and functions
+ until the end of its current transaction. So the statistics will show
+ static information as long as you continue the current transaction.
+ Similarly, information about the current queries of all sessions is tracked
+ when any such information is first requested within a transaction, and the
+ same information will be displayed throughout the transaction. This is a
+ feature, not a bug, because it allows you to perform several queries on the
+ statistics and correlate the results without worrying that the numbers are
+ changing underneath you. But if you want to see new results with each
+ query, be sure to do the queries outside any transaction block.
+ Alternatively, you can invoke
<function>pg_stat_clear_snapshot</function>(), which will discard the
current transaction's statistics snapshot (if any). The next use of
statistical information will cause a new snapshot to be fetched.
</para>
-
+
<para>
- A transaction can also see its own statistics (as yet untransmitted to the
- collector) in the views <structname>pg_stat_xact_all_tables</structname>,
+ A transaction can also see its own statistics (as yet unwritten to the
+ server-wide activity statistics) in the
+ views <structname>pg_stat_xact_all_tables</structname>,
<structname>pg_stat_xact_sys_tables</structname>,
<structname>pg_stat_xact_user_tables</structname>, and
<structname>pg_stat_xact_user_functions</structname>. These numbers do not act as
@@ -643,7 +633,7 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
kernel's I/O cache, and might therefore still be fetched without
requiring a physical read. Users interested in obtaining more
detailed information on <productname>PostgreSQL</productname> I/O behavior are
- advised to use the <productname>PostgreSQL</productname> statistics collector
+ advised to use the <productname>PostgreSQL</productname> activity statistics
in combination with operating system utilities that allow insight
into the kernel's handling of I/O.
</para>
@@ -1080,10 +1070,6 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
<entry><literal>LogicalLauncherMain</literal></entry>
<entry>Waiting in main loop of logical replication launcher process.</entry>
</row>
- <row>
- <entry><literal>PgStatMain</literal></entry>
- <entry>Waiting in main loop of statistics collector process.</entry>
- </row>
<row>
<entry><literal>RecoveryWalStream</literal></entry>
<entry>Waiting in main loop of startup process for WAL to arrive, during
@@ -1838,6 +1824,10 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
</thead>
<tbody>
+ <row>
+ <entry><literal>ActivityStatistics</literal></entry>
+ <entry>Waiting to write out activity statistics to shared memory.</entry>
+ </row>
<row>
<entry><literal>AddinShmemInit</literal></entry>
<entry>Waiting to manage an extension's space allocation in shared
@@ -6071,9 +6061,10 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<entry><literal>performing final cleanup</literal></entry>
<entry>
<command>VACUUM</command> is performing final cleanup. During this phase,
- <command>VACUUM</command> will vacuum the free space map, update statistics
- in <literal>pg_class</literal>, and report statistics to the statistics
- collector. When this phase is completed, <command>VACUUM</command> will end.
+ <command>VACUUM</command> will vacuum the free space map, update
+ statistics in <literal>pg_class</literal>, and system-wide activity
+ statistics. When this phase is completed, <command>VACUUM</command>
+ will end.
</entry>
</row>
</tbody>
diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml
index bcbb7a25fb..1fa59a2fdf 100644
--- a/doc/src/sgml/ref/pg_dump.sgml
+++ b/doc/src/sgml/ref/pg_dump.sgml
@@ -1280,11 +1280,10 @@ PostgreSQL documentation
</para>
<para>
- The database activity of <application>pg_dump</application> is
- normally collected by the statistics collector. If this is
- undesirable, you can set parameter <varname>track_counts</varname>
- to false via <envar>PGOPTIONS</envar> or the <literal>ALTER
- USER</literal> command.
+ The database activity of <application>pg_dump</application> is normally
+ collected. If this is undesirable, you can set
+ parameter <varname>track_counts</varname> to false
+ via <envar>PGOPTIONS</envar> or the <literal>ALTER USER</literal> command.
</para>
</refsect1>
--
2.27.0
----Next_Part(Fri_Mar__5_17_18_56_2021_497)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="v48-0006-Remove-the-GUC-stats_temp_directory.patch"
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [PING] fallocate() causes btrfs to never compress postgresql files
@ 2026-01-12 10:04 Jakub Wartak <[email protected]>
2026-02-06 05:11 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Thomas Munro <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Jakub Wartak @ 2026-01-12 10:04 UTC (permalink / raw)
To: Thomas Munro <[email protected]>; +Cc: Bruce Momjian <[email protected]>; Dimitrios Apostolou <[email protected]>; Magnus Hagander <[email protected]>; Tomas Vondra <[email protected]>; [email protected]; Andres Freund <[email protected]>; Melanie Plageman <[email protected]>; Heikki Linnakangas <[email protected]>; Kyotaro Horiguchi <[email protected]>; David Rowley <[email protected]>
On Mon, Dec 15, 2025 at 8:50 AM Jakub Wartak
<[email protected]> wrote:
>
> On Mon, Dec 15, 2025 at 7:00 AM Thomas Munro <[email protected]> wrote:
> >
> > Here's a new version with some cleanup and documentation. I tried to
> > pare it down to the minimum change for the back-branches, keeping
> > unnecessary changes for master. In the process, I also thought a bit
> > about how to de-confused matters on Windows, where the function we
> > call as ftruncate() behaves differently in a crucial respect. See
> > attached.
> >
> > I'm proposing to back-patch 0001. 0002 and 0003 are proposals for master only.
> >
>
> Hi Thomas,
>
> Thanks for working on this. I have reviewed and played a little with
> them and they are in very good shape, so +1 from my side. Just couple
> of minor things:
>
> 1. 0001 I would just add another Discussion there too in commit
> message (https://www.postgresql.org/message-id/flat/CADofcAV8xu3hCNHq7-7x56KrP9rD6%3DA04%3DqjTr3nETh-gptF8w%4...
> - XFS thread)
> 2. I've tested those lightly and they pass my local/built/test. Just a
> non-actionable observation from my side: I'm just not sure how useful
> the v2-0002 (the new file_extend_method_threshold) is going to be in
> real life, for me it sounds like it could be debug_file_extend*...
> however that would break convention of using just file_extend
> 3. I haven't tested 0003 as it is for Windows, probably we could add
> it to cfbot, so that it would tell us something more there.
>
> > See below for replies to separate messages from Jakub and Bruce.
> >
> > On Thu, Oct 30, 2025 at 11:14 PM Jakub Wartak
> > <[email protected]> wrote:
> > > +1 to this GUCs as this would also help the nearby thread with XFS
> > > mysteries which are not fully solved [1]. Since the latest message in
> > > that discussion, I'm aware of at least one additional report of XFS
> > > failing at fallocate() with free space too, but without any details
> > > from the OS support vendor why that happened, so this $patch could be
> > > also used to workaround that problem too.
> >
> > Yeah, that seems quite important, and the new report in psql-bugs
> > #19348 sounds like another case.
>
> Right, I think we've got another report internally too since last time
> we've talked, but contact went silent after being redirected to the OS
> vendor (after some recommended workaround did not work for them , but
> those worked for others).
>
> > > Why just 17? (wasn't fallocate() introduced in 16? 4d330a61bb19 and
> > > 31966b151e6ab are from Apr 2023, while 16 was released on Sep 2023)
> >
> > Right, fixed.
>
> Cool, thanks.
>
> > Yeah. Let's go with PGC_SIGHUP. Let's worry about multiple
> > filesystems when we've figured out how to do per-tablespace settings.
>
> Cool, thanks.
>
> > This is vapourware for later, but I've been wondering if we could
> > invent a sysctl-style hierarchy as a scoping mechanism, something
> > like:
> >
> > tablespace.foo.random_page_cost=1
> > tablespace.foo.file_extend_method=ftruncate
> > tablespace.foo.io_combine_limit=1MB
>
> This looks more like sysfs than sysctl (as foo is tablespace name?)
> :^). Anyway I think that 0001 should go in and then new thread could
> be started for this if You want (as this would be a little conflicting
> to stuff we already have: e.g. alter tablespace pg_default set
> (maintenance_io_concurrency=XXX), but it is highly unlikely anybody
> uses '\db+' in psql see those options there).
Good morning Thomas,
Do you have any plans to commit this before February (before next
minor release) or perhaps do you need some further input or help in
this $thread? (I'm mainly after the XFS thingy, but we kill two birds
with 1 stone here).
-J.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [PING] fallocate() causes btrfs to never compress postgresql files
2026-01-12 10:04 Re: [PING] fallocate() causes btrfs to never compress postgresql files Jakub Wartak <[email protected]>
@ 2026-02-06 05:11 ` Thomas Munro <[email protected]>
2026-02-06 07:19 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Jakub Wartak <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Munro @ 2026-02-06 05:11 UTC (permalink / raw)
To: Jakub Wartak <[email protected]>; +Cc: Bruce Momjian <[email protected]>; Dimitrios Apostolou <[email protected]>; Magnus Hagander <[email protected]>; Tomas Vondra <[email protected]>; [email protected]; Andres Freund <[email protected]>; Melanie Plageman <[email protected]>; Heikki Linnakangas <[email protected]>; Kyotaro Horiguchi <[email protected]>; David Rowley <[email protected]>
On Mon, Jan 12, 2026 at 11:04 PM Jakub Wartak
<[email protected]> wrote:
> > > I'm proposing to back-patch 0001. 0002 and 0003 are proposals for master only.
> Do you have any plans to commit this before February (before next
> minor release) or perhaps do you need some further input or help in
> this $thread? (I'm mainly after the XFS thingy, but we kill two birds
> with 1 stone here).
Pushed.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [PING] fallocate() causes btrfs to never compress postgresql files
2026-01-12 10:04 Re: [PING] fallocate() causes btrfs to never compress postgresql files Jakub Wartak <[email protected]>
2026-02-06 05:11 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Thomas Munro <[email protected]>
@ 2026-02-06 07:19 ` Jakub Wartak <[email protected]>
2026-02-06 08:29 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Thomas Munro <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Jakub Wartak @ 2026-02-06 07:19 UTC (permalink / raw)
To: Thomas Munro <[email protected]>; +Cc: Bruce Momjian <[email protected]>; Dimitrios Apostolou <[email protected]>; Magnus Hagander <[email protected]>; Tomas Vondra <[email protected]>; [email protected]; Andres Freund <[email protected]>; Melanie Plageman <[email protected]>; Heikki Linnakangas <[email protected]>; Kyotaro Horiguchi <[email protected]>; David Rowley <[email protected]>; Andrew Dunstan <[email protected]>
On Fri, Feb 6, 2026 at 6:12 AM Thomas Munro <[email protected]> wrote:
>
> On Mon, Jan 12, 2026 at 11:04 PM Jakub Wartak
> <[email protected]> wrote:
> > > > I'm proposing to back-patch 0001. 0002 and 0003 are proposals for master only.
>
> > Do you have any plans to commit this before February (before next
> > minor release) or perhaps do you need some further input or help in
> > this $thread? (I'm mainly after the XFS thingy, but we kill two birds
> > with 1 stone here).
>
> Pushed.
Thank You very much !
-J.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [PING] fallocate() causes btrfs to never compress postgresql files
2026-01-12 10:04 Re: [PING] fallocate() causes btrfs to never compress postgresql files Jakub Wartak <[email protected]>
2026-02-06 05:11 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Thomas Munro <[email protected]>
2026-02-06 07:19 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Jakub Wartak <[email protected]>
@ 2026-02-06 08:29 ` Thomas Munro <[email protected]>
2026-02-06 14:12 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Andrew Dunstan <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Munro @ 2026-02-06 08:29 UTC (permalink / raw)
To: Jakub Wartak <[email protected]>; +Cc: Bruce Momjian <[email protected]>; Dimitrios Apostolou <[email protected]>; Magnus Hagander <[email protected]>; Tomas Vondra <[email protected]>; [email protected]; Andres Freund <[email protected]>; Melanie Plageman <[email protected]>; Heikki Linnakangas <[email protected]>; Kyotaro Horiguchi <[email protected]>; David Rowley <[email protected]>; Andrew Dunstan <[email protected]>
On Fri, Feb 6, 2026 at 8:19 PM Jakub Wartak
<[email protected]> wrote:
> On Fri, Feb 6, 2026 at 6:12 AM Thomas Munro <[email protected]> wrote:
> > On Mon, Jan 12, 2026 at 11:04 PM Jakub Wartak
> > <[email protected]> wrote:
> > > > > I'm proposing to back-patch 0001. 0002 and 0003 are proposals for master only.
> >
> > > Do you have any plans to commit this before February (before next
> > > minor release) or perhaps do you need some further input or help in
> > > this $thread? (I'm mainly after the XFS thingy, but we kill two birds
> > > with 1 stone here).
> >
> > Pushed.
>
> Thank You very much !
BTW the rest of the patches will reemerge for master, but for the
minimal one back-patched: crake complains about an ABI break due to
GUC table changes. Of course adding a GUC to the stable branches is
unusual and we discussed the need for it in this case. Is that
expected? In what way is it part of the ABI? How would one determine
in advance that the ABI checker will complain?
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [PING] fallocate() causes btrfs to never compress postgresql files
2026-01-12 10:04 Re: [PING] fallocate() causes btrfs to never compress postgresql files Jakub Wartak <[email protected]>
2026-02-06 05:11 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Thomas Munro <[email protected]>
2026-02-06 07:19 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Jakub Wartak <[email protected]>
2026-02-06 08:29 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Thomas Munro <[email protected]>
@ 2026-02-06 14:12 ` Andrew Dunstan <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Dunstan @ 2026-02-06 14:12 UTC (permalink / raw)
To: Thomas Munro <[email protected]>; Jakub Wartak <[email protected]>; +Cc: Bruce Momjian <[email protected]>; Dimitrios Apostolou <[email protected]>; Magnus Hagander <[email protected]>; Tomas Vondra <[email protected]>; [email protected]; Andres Freund <[email protected]>; Melanie Plageman <[email protected]>; Heikki Linnakangas <[email protected]>; Kyotaro Horiguchi <[email protected]>; David Rowley <[email protected]>
On 2026-02-06 Fr 3:29 AM, Thomas Munro wrote:
> On Fri, Feb 6, 2026 at 8:19 PM Jakub Wartak
> <[email protected]> wrote:
>> On Fri, Feb 6, 2026 at 6:12 AM Thomas Munro <[email protected]> wrote:
>>> On Mon, Jan 12, 2026 at 11:04 PM Jakub Wartak
>>> <[email protected]> wrote:
>>>>>> I'm proposing to back-patch 0001. 0002 and 0003 are proposals for master only.
>>>> Do you have any plans to commit this before February (before next
>>>> minor release) or perhaps do you need some further input or help in
>>>> this $thread? (I'm mainly after the XFS thingy, but we kill two birds
>>>> with 1 stone here).
>>> Pushed.
>> Thank You very much !
> BTW the rest of the patches will reemerge for master, but for the
> minimal one back-patched: crake complains about an ABI break due to
> GUC table changes. Of course adding a GUC to the stable branches is
> unusual and we discussed the need for it in this case. Is that
> expected? In what way is it part of the ABI? How would one determine
> in advance that the ABI checker will complain?
>
>
First, thanks for committing this.
How to tell it will detect a break is a good question. I guess a trivial
answer would be to run the buildfarm client with the ABICompCheck module
enabled, but that's probably a big ask if you're not set up for it. This
one is relatively hard to catch because tthe ABI change is in a
generated file, so the triggering source change isn't even in the
include directory.
Not sure if we want to start using a suppressions file to exclude
certain symbols from consideration. They are described here
https://man7.org/linux/man-pages/man7/libabigail.7.html
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-02-06 14:12 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-03-19 06:11 [PATCH v48 5/7] Doc part of shared-memory based stats collector. Kyotaro Horiguchi <[email protected]>
2026-01-12 10:04 Re: [PING] fallocate() causes btrfs to never compress postgresql files Jakub Wartak <[email protected]>
2026-02-06 05:11 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Thomas Munro <[email protected]>
2026-02-06 07:19 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Jakub Wartak <[email protected]>
2026-02-06 08:29 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Thomas Munro <[email protected]>
2026-02-06 14:12 ` Re: [PING] fallocate() causes btrfs to never compress postgresql files Andrew Dunstan <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox