From: Jeff Davis <pgsql@j-davis.com>
To: Peter Geoghegan <pg@bowt.ie>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Default setting for enable_hashagg_disk
Date: Mon, 27 Jul 2020 17:10:41 -0700
Message-ID: <75b987c43ea03900f83e3612f43e2ffc841db553.camel@j-davis.com> (raw)
In-Reply-To: <CAH2-Wznmr5r2GtRh4h7AYP+d6EGyKFmKg39wp71ei2UC5db3zA@mail.gmail.com>
References: <CAH2-Wzngb2TVfJc=eC_oXYsRKix_2Cc+ooHR-vb=qJ9kcAYWDA@mail.gmail.com>
<20200727182436.GA20148@alvherre.pgsql>
<CAH2-Wznmr5r2GtRh4h7AYP+d6EGyKFmKg39wp71ei2UC5db3zA@mail.gmail.com>
On Mon, 2020-07-27 at 11:30 -0700, Peter Geoghegan wrote:
> The v4-0001-Remove-hashagg_avoid_disk_plan-GUC.patch changes are
> surprisingly complicated. It would be nice if you could take a look
> at
> that aspect (or confirm that it's included in your review).
I noticed that one of the conditionals, "cheapest_total_path != NULL",
was already redundant with the outer conditional before your patch. I
guess that was just a mistake which your patch corrects along the way?
Anyway, the patch looks good to me. We can have a separate discussion
about pessimizing the costing, if necessary.
Regards,
Jeff Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pgsql@j-davis.com, pg@bowt.ie, alvherre@2ndquadrant.com, dgrowleyml@gmail.com, sfrost@snowman.net, tgl@sss.pgh.pa.us, andres@anarazel.de, bruce@momjian.us, robertmhaas@gmail.com, pryzby@telsasoft.com, melanieplageman@gmail.com, tomas.vondra@2ndquadrant.com
Subject: Re: Default setting for enable_hashagg_disk
In-Reply-To: <75b987c43ea03900f83e3612f43e2ffc841db553.camel@j-davis.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox