From: Tom Lane <tgl@sss.pgh.pa.us>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Narek Galstyan <narek.galstyan@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org, "narekg@berkeley.edu" <narekg@berkeley.edu>
Cc: ngalstyan4@gmail.com
Subject: Re: Coverage with make coverage-html is broken on latest Debian using lcov v2
Date: Sat, 03 Oct 2026 12:39:29 -0400
Message-ID: <77254.1791045569@sss.pgh.pa.us> (raw)
In-Reply-To: <ajBA9Zuy3TZ73mxr@alvherre.pgsql>
References: <ajBA9Zuy3TZ73mxr@alvherre.pgsql>
[ This thread went quiet, but you reminded me of it in answering
Pierre Forstmann's nearby question ]
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> Handling this part with your 0001 seems reasonable to me. I think we
> should backpatch that one.
Agreed, and it doesn't look like that got done, so I'll go do it now.
> I'm not sure sure about the 0002 patch though. It builds in the
> assumption that lcov is broken and that we're going to ignore these
> warnings by default [forever]. Do we really want to bake those flags
> into our build system?
That bothers me too, mainly because I foresee a risk of the switches
hiding genuine problems somewhere down the road. Also the switches
Narek proposes don't match what I've found to be necessary on my
own installation (so maybe there is a gcov version dependency here
too?).
For the moment I'm content to insert the --ignore-errors flags
manually. The 0001 patch should at least reduce the noise level
a bit.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@kurilemu.de, narek.galstyan@enterprisedb.com, narekg@berkeley.edu, ngalstyan4@gmail.com
Subject: Re: Coverage with make coverage-html is broken on latest Debian using lcov v2
In-Reply-To: <77254.1791045569@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox