pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: John Naylor <john.naylor@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: John Naylor <jcnaylor@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: optimize lookups in snapshot [sub]xip arrays
Date: Tue, 09 Aug 2022 01:12:53 -0400
Message-ID: <776831.1660021973@sss.pgh.pa.us> (raw)
In-Reply-To: <20220809044317.GA1443152@nathanxps13>
References: <20220804221551.GA1090071@nathanxps13>
	<CAFBsxsGmNefB-LAo8hNXLDAwWN0vHXc6H2A+NfFUQrj=rn50DQ@mail.gmail.com>
	<20220805202510.GA1208450@nathanxps13>
	<20220805220434.6h2aa7eww5rxird6@awork3.anarazel.de>
	<20220806181326.GA1216305@nathanxps13>
	<20220806212522.GA1221353@nathanxps13>
	<CAFBsxsFCtNAxbmSc9dc6xbF4HguBmMB7CDjm+8Z7uWEfTN+7oA@mail.gmail.com>
	<CALj2ACVsE23YMWU5Sn2aZwMq_0m-rK3r6ARZXUM11bSsZnKm+Q@mail.gmail.com>
	<20220808230716.GB1393216@nathanxps13>
	<CALj2ACUQVxHfOUKkhf4RAqmGGvKtzoUBMchHCgNyV+w8a-Yx1A@mail.gmail.com>
	<20220809044317.GA1443152@nathanxps13>

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Tue, Aug 09, 2022 at 09:40:15AM +0530, Bharath Rupireddy wrote:
>> Isn't it a good idea to capture the above two points as comments in
>> port/pg_lfind.h just to not lose track of it? I know these are present
>> in the hackers thread, but having them in the form of comments helps
>> developers who attempt to change or use the new function.

> Hm.  My first impression is that this is exactly the sort of information
> that is better captured on the lists.  I'm not sure that the lack of such
> commentary really poses any threat for future changes, which would need to
> be judged on their own merit, anyway.

It's clearly unproductive (not to say impossible) to enumerate every
possible alternative design and say why you didn't choose it.  If
there's some particular "obvious" choice that you feel a need to
refute, then sure write a comment about that.  Notably, if we used
to do X and now do Y because X was found to be broken, then it's good
to have a comment trail discouraging future hackers from reinventing
X.  But that doesn't lead to needing comments about an unrelated
option Z.

			regards, tom lane





view thread (48+ messages)  latest in thread

Message-ID: <776831.1660021973@sss.pgh.pa.us>
Permalink:  ../776831.1660021973@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/776831.1660021973@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, bharath.rupireddyforpostgres@gmail.com, john.naylor@enterprisedb.com, andres@anarazel.de, jcnaylor@gmail.com
  Subject: Re: optimize lookups in snapshot [sub]xip arrays
  In-Reply-To: <776831.1660021973@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox