public inbox for [email protected]
help / color / mirror / Atom feedFrom: Daniel Gustafsson <[email protected]>
To: Robert Haas <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Mikhail Gribkov <[email protected]>
Cc: [email protected]
Subject: Re: GUC for temporarily disabling event triggers
Date: Wed, 5 Apr 2023 20:43:07 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoYJdpN6AJ87q0sEY+NEee9SkMyLp-W-kSdkYpwi6yP3+w@mail.gmail.com>
References: <[email protected]>
<CALte62x7c9R0ohKcQSr5N9PFB-D6pCb_THhwWzTscR7ZB6OHvg@mail.gmail.com>
<167482801126.1114.1095311628314619931.pgcf@coridan.postgresql.org>
<[email protected]>
<[email protected]>
<[email protected]>
<CA+Tgmoa7ODAMvJn8sncmMzxkHL=hKmqXa3TLqh-SCLmiB64qzQ@mail.gmail.com>
<[email protected]>
<CA+TgmoZDjc04aPD0LM4LKZ_GstggvAzxmmhWdeX0iHrnC1V2Yg@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CA+TgmoYJdpN6AJ87q0sEY+NEee9SkMyLp-W-kSdkYpwi6yP3+w@mail.gmail.com>
> On 5 Apr 2023, at 16:30, Robert Haas <[email protected]> wrote:
>
> On Wed, Apr 5, 2023 at 4:57 AM Daniel Gustafsson <[email protected]> wrote:
>>> - Being able to write a list of event triggers working would be much
>>> more interesting than just individual elements.
>>> - There may be an argument for negated patterns? Say,
>>> a "!sql_drop,!ddl_command_start" would cause sql_drop and
>>> ddl_command_start to be disabled with all the others enabled, and one
>>> should not ne able to mix negated and non-negated patterns.
>>
>> I'm not convinced that it's in our interest to offer a GUC to configure the
>> cluster by selectively turning off SQL features. The ones we have for planner
>> tuning which is a different beast. At the very least it should be in a thread
>> covering that topic, as it might be a bit hidden here.
>
> But, isn't that exactly what you're proposing?
Yeah, but it didn't really strike me until after typing and sending that email.
> I mean if this was just event_triggers = on | off it would be exactly
> like row_security and as far as I'm concerned there would be nothing
> to debate.
Which is what v1-v3 did until I changed it based on review input, but I agree
with the reasoning here so will revert back (with some internal changes too).
Moving this to the next CF for another stab at it when the tree re-opens.
--
Daniel Gustafsson
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: GUC for temporarily disabling event triggers
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox