From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: torikoshia <torikoshia@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Creating a function for exposing memory usage of backend process
Date: Mon, 29 Jun 2020 15:13:13 +0900
Message-ID: <78268b5f-53ed-4645-1abb-23c1030cce0a@oss.nttdata.com> (raw)
In-Reply-To: <3193c7d590f3212e543b63df977da758@oss.nttdata.com>
References: <72a656e0f71d0860161e0b3f67e4d771@oss.nttdata.com>
<398eb7cd-5f75-be1c-3897-36865b7bfabf@oss.nttdata.com>
<CA+TgmobkpFV0UB67kzXuD36--OFHwz1bs=L_6PZbD4nxKqUQMw@mail.gmail.com>
<3193c7d590f3212e543b63df977da758@oss.nttdata.com>
On 2020/06/29 12:01, torikoshia wrote:
> On 2020-06-20 03:11, Robert Haas wrote:
>> On Wed, Jun 17, 2020 at 11:56 PM Fujii Masao
>> <masao.fujii@oss.nttdata.com> wrote:
>>> > As a first step, to deal with (3) I'd like to add
>>> > pg_stat_get_backend_memory_context() which target is limited to the
>>> > local backend process.
>>>
>>> +1
>>
>> +1 from me, too.
>
> Attached a patch that adds a function exposing memory usage of local
> backend.
Thanks for the patch!
Could you add this patch to Commitfest 2020-07?
>
> It's almost same as pg_cheat_funcs's pg_stat_get_memory_context().
This patch provides only the function, but isn't it convenient to
provide the view like pg_shmem_allocations?
> I've also added MemoryContexts identifier because it seems useful to
> distinguish the same kind of memory contexts.
Sounds good. But isn't it better to document each column?
Otherwise, users cannot undersntad what "ident" column indicates.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, torikoshia@oss.nttdata.com
Subject: Re: Creating a function for exposing memory usage of backend process
In-Reply-To: <78268b5f-53ed-4645-1abb-23c1030cce0a@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox