public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: SATYANARAYANA NARLAPURAM <[email protected]>
To: Jeff Davis <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Japin Li <[email protected]>
Cc: Zsolt Parragi <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pg_get__*_ddl consolidation
Date: Tue, 14 Apr 2026 18:52:04 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHg+QDdWtv9PKtPZEokwGCNtbv4MVnfYw5wMZrsEj4xizSNe5Q@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CAN4CZFNYM5jNA_gLu9miAXg_7c8Z2zf-ePc+0rzidAV3CBs=cw@mail.gmail.com>
	<[email protected]>
	<SY7PR01MB10921A6E1E08A48F3426FE529B651A@SY7PR01MB10921.ausprd01.prod.outlook.com>
	<CAKFQuwYcppypeGBwa7ZbDAfoUXSv+kLhJuAXsdwBmKrvy8wDFw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAHg+QDdWtv9PKtPZEokwGCNtbv4MVnfYw5wMZrsEj4xizSNe5Q@mail.gmail.com>


On 2026-04-13 Mo 3:41 PM, SATYANARAYANA NARLAPURAM wrote:
> Hi,
>
> On Fri, Apr 10, 2026 at 1:03 PM Jeff Davis <[email protected]> wrote:
>
>     On Sun, 2026-04-05 at 11:06 -0400, Andrew Dunstan wrote:
>     > Pushed. I have moved the remaining get_*_ddl items to PG20-1
>
>     The line:
>
>       role_settings = DatumGetArrayTypeP(datum);
>
>     should be DatumGetArrayTypePCopy(), because it's being pfree()d later.
>     The existing code will sometimes make a copy and sometimes not, e.g.:
>
>       -- settings are contrived to make the datum inline
>       CREATE USER u1;
>       ALTER ROLE u1 SET search_path = 'public, pg_catalog, pg_temp';
>       ALTER ROLE u1 SET work_mem='64MB';
>       ALTER ROLE u1 SET statement_timeout='30s';
>       ALTER ROLE u1 SET lock_timeout='10s';
>       ALTER ROLE u1 SET idle_in_transaction_session_timeout = '60s';
>       SELECT pg_get_role_ddl('u1');
>       ERROR:  pfree called with invalid pointer 0x7986dd0c7cc8 (header
>     0x0000400600000000)
>
>
> Yes, it appears to be a bug. Attached a patch to fix this. Tested with 
> the
> attached patch and don't see server crashing after that.
>
>

Thanks, pushed.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

view thread (31+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pg_get__*_ddl consolidation
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox