pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dag Lem <dag@nimrod.no>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Run UTF8-dependent tests for citext [Re: daitch_mokotoff module]
Date: Wed, 05 Jan 2022 13:38:42 -0500
Message-ID: <793161.1641407922@sss.pgh.pa.us> (raw)
In-Reply-To: <ygezgoacs4e.fsf_-_@sid.nimrod.no>
References: <yger1atbgfy.fsf@sid.nimrod.no>
	<ygek0g87hgx.fsf@sid.nimrod.no>
	<0cac2d60-5b85-59c6-1ac1-77092b8688b7@enterprisedb.com>
	<ygelf0mizon.fsf@sid.nimrod.no>
	<yge7dbxhc01.fsf@sid.nimrod.no>
	<20220102213150.y2tpuwqhruu5t2y5@alap3.anarazel.de>
	<CA+hUKG+Gs3WXzbT4OK9gEXpC1e221RafrPS4LVvcDDgDi20xAg@mail.gmail.com>
	<3461033.1641177713@sss.pgh.pa.us>
	<ygeo84tvugy.fsf@sid.nimrod.no>
	<3563190.1641227676@sss.pgh.pa.us>
	<ygezgoacs4e.fsf_-_@sid.nimrod.no>

Dag Lem <dag@nimrod.no> writes:
> Please find attached a patch to run the previously commented-out
> UTF8-dependent tests for citext, according to best practice. For now I
> don't dare to touch the unaccent module, which seems to be UTF8-only
> anyway.

I tried this on a bunch of different locale settings and concluded that
we need to restrict the locale to avoid failures: it falls over with
locale C.  With that, it passes on all UTF8 LANG settings on RHEL8
and FreeBSD 12, and all except am_ET.UTF-8 on current macOS.  I'm not
sure what the deal is with am_ET, but macOS has a long and sad history
of wonky UTF8 locales, so I was actually expecting worse.  If the
buildfarm shows more problems, we can restrict it further --- I won't
be too upset if we end up restricting to just Linux systems, like
collate.linux.utf8.  Anyway, pushed to see what happens.

			regards, tom lane





view thread (2+ messages)

Message-ID: <793161.1641407922@sss.pgh.pa.us>
Permalink:  ../793161.1641407922@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/793161.1641407922@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dag@nimrod.no, pgsql-hackers@lists.postgresql.org
  Subject: Re: [PATCH] Run UTF8-dependent tests for citext [Re: daitch_mokotoff module]
  In-Reply-To: <793161.1641407922@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox