From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Wrong results from in_range() tests with infinite offset
Date: Mon, 20 Jul 2020 22:06:32 -0400
Message-ID: <794665.1595297192@sss.pgh.pa.us> (raw)
In-Reply-To: <4166230.1595107732@sss.pgh.pa.us>
References: <3393130.1594925893@sss.pgh.pa.us>
<3464257.1594936216@sss.pgh.pa.us>
<CAEZATCVXfxCR+2gCSwFMQPfyFUVNzY7U6oHfCfjD1OCCVfWUiQ@mail.gmail.com>
<3506768.1594947597@sss.pgh.pa.us>
<CAEZATCVQO1vUXo0PjHToxvyZ8piwH-u-mTMqMhrGku2dYMhWbw@mail.gmail.com>
<3941233.1595081173@sss.pgh.pa.us>
<4166230.1595107732@sss.pgh.pa.us>
I wrote:
> The other three cases where we'd hit NaNs are likewise symmetric with
> non-NaN cases that'd return TRUE. Hence, I'm forced to the conclusion
> that you've got it right above. I might write the code a little
> differently, but const-TRUE-for-NaN-cases seems like the right behavior.
> So I withdraw my objection to defining it this way. Unless somebody
> else weighs in, I'll commit it like that in a day or two.
Pushed, but I chickened out of back-patching. The improvement in what
happens for finite comparison values seems somewhat counterbalanced by
the possibility that someone might not like the definition we arrived
at for infinities. So, it's not quite an open-and-shut bug fix, so
I just put it in HEAD (for now anyway).
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, dean.a.rasheed@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Wrong results from in_range() tests with infinite offset
In-Reply-To: <794665.1595297192@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox