pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Noah Misch <noah@leadboat.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improving isolationtester's data output
Date: Wed, 16 Jun 2021 15:33:29 -0400
Message-ID: <794820.1623872009@sss.pgh.pa.us> (raw)
In-Reply-To: <202106161514.3xomrhb3kq5a@alvherre.pgsql>
References: <202106161514.3xomrhb3kq5a@alvherre.pgsql>

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2021-Jun-16, Tom Lane wrote:
>> Hearing few objections, I'll plan on back-patching.  I'm thinking that the
>> best thing to do is apply these changes after beta2 wraps, but before we
>> branch v14.

> Great.

After checking cross-version diffs to see how painful that is likely
to be, I'm inclined to also back-patch Michael's v13 commits

989d23b04beac0c26f44c379b04ac781eaa4265e
    Detect unused steps in isolation specs and do some cleanup

9903338b5ea59093d77cfe50ec0b1c22d4a7d843
    Remove dry-run mode from isolationtester

as those touched some of the same code areas, and it doesn't seem like
there'd be any harm in making these aspects uniform across all the
branches.  If Michael wants to do that back-patching himself, that's
fine with me, otherwise I'll do it.

Also, having slept on it, I'm leaning towards to the approach of
using PQprint() instead of just tweaking the existing code.  At first
I thought that was too much churn in the output files, but it really
does seem to make them significantly more readable.

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <794820.1623872009@sss.pgh.pa.us>
Permalink:  ../794820.1623872009@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/794820.1623872009@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, michael@paquier.xyz, noah@leadboat.com, andres@anarazel.de
  Subject: Re: Improving isolationtester's data output
  In-Reply-To: <794820.1623872009@sss.pgh.pa.us>
  References: <202106161514.3xomrhb3kq5a@alvherre.pgsql> <794820.1623872009@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox