pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bossart, Nathan <bossartn@amazon.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: Improving psql's \password command
Date: Sat, 20 Nov 2021 23:25:43 +0000
Message-ID: <7E82AB1D-5D14-458F-8AD3-FFB71B7FAD67@amazon.com> (raw)
In-Reply-To: <3349562.1637445476@sss.pgh.pa.us>
References: <747443.1635536754@sss.pgh.pa.us>
	<C2787D93-6871-4D93-9CF3-CD7BB489F47F@amazon.com>
	<765509.1635552418@sss.pgh.pa.us>
	<7BAC8A28-148B-4B03-A345-D68071388300@amazon.com>
	<1553329.1636647111@sss.pgh.pa.us>
	<E0C46CDF-46B2-4388-B53B-96EB2CA0F71E@amazon.com>
	<1847699.1636747076@sss.pgh.pa.us>
	<AEA1BA57-BD21-4237-9859-1C04FE38602B@amazon.com>
	<2141902.1636999964@sss.pgh.pa.us>
	<5EDA38EF-C411-4C7D-A9BC-10B1D4584E5E@amazon.com>
	<2152988.1637010233@sss.pgh.pa.us>
	<E4840C66-2FD5-4A0B-8CC9-A09F8B9126B7@amazon.com>
	<2850852.1637194468@sss.pgh.pa.us>
	<450C0AD1-CF21-4056-A9EE-6201E9763FC9@amazon.com>
	<3085404.1637342157@sss.pgh.pa.us>
	<9D3BFA94-DEF2-4B43-B240-8ADC595ECA7A@amazon.com>
	<3349562.1637445476@sss.pgh.pa.us>

On 11/20/21, 1:58 PM, "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
> "Bossart, Nathan" <bossartn@amazon.com> writes:
>> I did find some missing control-C handling in
>> pg_receivewal/pg_recvlogical, though.  Attached is a patch for those.
>
> Meh ... I'm inclined to fix those programs by just moving their pqsignal
> calls down to after their initial GetConnection calls, as attached.
> This'd be simple enough to back-patch, for one thing.
>
> It could be argued that this doesn't provide a nice experience if
> (a) somebody changes your password mid-run and (b) you actually
> need to make a new connection for some reason and (c) you want
> to give up at that point instead of putting in the new password.
> But I doubt it's worth so much extra complication to address that
> edge case.  We've had about zero field complaints about the existing
> behavior in those programs, so the cost/benefit ratio seems poor.

Yeah, I was looking for a way to simplify this, too.  Your approach
seems reasonable enough to me.

Nathan



view thread (22+ messages)  latest in thread

Message-ID: <7E82AB1D-5D14-458F-8AD3-FFB71B7FAD67@amazon.com>
Permalink:  ../7E82AB1D-5D14-458F-8AD3-FFB71B7FAD67@amazon.com/
Also on:    postgresql.org/message-id/7E82AB1D-5D14-458F-8AD3-FFB71B7FAD67@amazon.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bossartn@amazon.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: Improving psql's \password command
  In-Reply-To: <7E82AB1D-5D14-458F-8AD3-FFB71B7FAD67@amazon.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox