public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ilia Evdokimov <[email protected]>
To: Alena Rybakina <[email protected]>
To: Andrei Zubkov <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: [email protected]
Subject: Re: Vacuum statistics
Date: Thu, 15 Aug 2024 12:50:58 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>


On 15.8.24 11:49, Alena Rybakina wrote:
>>
>> I have some suggestions:
>>
>>  1. pgstatfuncs.c in functions tuplestore_put_for_database() and
>>     tuplestore_put_for_relation you can remove 'nulls' array if
>>     you're sure that columns cannot be NULL.
>>
> We need to use this for tuplestore_putvalues function. With this 
> function, we fill the table with the values of the statistics.

Ah, right! I'm sorry.


>> 1.
>>
>>
>>
>>  2. These functions are almost the same and I would think of writing
>>     one function depending of type 'ExtVacReportType'
>>
> I'm not sure that I fully understand what you mean. Can you explain it 
> more clearly, please?


Ah, I didn't notice that the size of all three tables is different. 
Therefore, it won't be possible to write one function instead of two to 
avoid code duplication. My mistake.

view thread (34+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Vacuum statistics
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox