From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: pryzby@telsasoft.com
Cc: noriyoshi.shinoda@hpe.com
Cc: pgsql-hackers@postgresql.org
Cc: rjuju123@gmail.com
Cc: tgl@sss.pgh.pa.us
Subject: Re: Improve logging when using Huge Pages
Date: Fri, 17 Sep 2021 00:13:41 +0900
Message-ID: <7ad09915-d8b1-1bce-b962-7062e2cf346a@oss.nttdata.com> (raw)
In-Reply-To: <20210908.111736.355857044349579789.horikyota.ntt@gmail.com>
References: <TU4PR8401MB115257079749D8958A3450F7EED39@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
<b707355a-84ba-9f8b-6026-8fac36121279@oss.nttdata.com>
<20210907131653.GK26465@telsasoft.com>
<20210908.111736.355857044349579789.horikyota.ntt@gmail.com>
On 2021/09/08 11:17, Kyotaro Horiguchi wrote:
> I don't dislike the message, but I'm not sure I like the message is
> too verbose, especially about it has DETAILS. It seems to me something
> like the following is sufficient, or I'd like see it even more concise.
>
> "fall back anonymous shared memory to non-huge pages: required %zu bytes for huge pages"
>
> If we emit an error message for other than mmap failure, it would be
> like the following.
>
> "fall back anonymous shared memory to non-huge pages: huge pages not available"
How about simpler message like "disabling huge pages" or
"disabling huge pages due to lack of huge pages available"?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, horikyota.ntt@gmail.com, pryzby@telsasoft.com, noriyoshi.shinoda@hpe.com, rjuju123@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: Improve logging when using Huge Pages
In-Reply-To: <7ad09915-d8b1-1bce-b962-7062e2cf346a@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox