public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: Jacob Champion <[email protected]>
To: Dagfinn Ilmari Mannsåker <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Tom Lane <[email protected]>
Subject: Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events
Date: Tue, 12 Aug 2025 18:21:01 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAOYmi+n6ORcmV10k+dAs+p0b9QJ4bfpk0WuHQaF5ODXxM8Y36A@mail.gmail.com>
References: <CAOYmi+nDZxJHaWj9_jRSyf8uMToCADAmOfJEggsKW-kY7aUwHA@mail.gmail.com>
<CAOYmi+mRhhzGUvrcdickepAnsdaGbqhNcboNe4-YvgtkSzGNbQ@mail.gmail.com>
<CA+hUKGLyS-GK_rkENaVbFVTa4VJ+reJxWtt+q4gmgNUXhptfYA@mail.gmail.com>
<CAOYmi+k1q3feeMxfbaJA=+hx+XnOFQA0z2JU+0igA7fTUZTmoA@mail.gmail.com>
<CA+hUKG+H1gwDh96jn5jB6Q3HyXrSC9x2y=uQJAthT8NLs6GN_Q@mail.gmail.com>
<CAOYmi+n1xRNCDnwZzigXVk8V=+sr7ZzuGpJ0tAyozX-zQT19Gg@mail.gmail.com>
<CAOYmi+mvk8Y7btYJhBzOGiNTY3cCpYZKjhA4-TP2Lkb=zOr4oQ@mail.gmail.com>
<[email protected]>
<CAOYmi+=9J0nA7XfUCaEdjUdAb9+L6nLoJCEGRYXZbUtZ_o2k5Q@mail.gmail.com>
<[email protected]>
<CAOYmi+nUAU+eJx__j6Uhmn3QV2G6NTdbL-_OJA1YQmscmKZiqw@mail.gmail.com>
<[email protected]>
<CAOYmi+m6t7r3jvDH-vUmy+GS_ZhstnPViE6Hee8c_M=_ASM9hg@mail.gmail.com>
<CAOYmi+n6ORcmV10k+dAs+p0b9QJ4bfpk0WuHQaF5ODXxM8Y36A@mail.gmail.com>
On 2025-08-12 Tu 6:11 PM, Jacob Champion wrote:
> On Fri, Aug 8, 2025 at 2:31 PM Jacob Champion
> <[email protected]> wrote:
>> Well, thank you for the explanation. I'll make that change.
> Done in v5.
>
> v5-0001 is planned for backport to 18 once the freeze lifts. It
> ensures that -lm is part of the link line for libpq-oauth, since the
> module uses floor(). I probably wouldn't have ever noticed, except
> that the new test executable, which uses the same link flags,
> complained on Clang [1].
>
> (In that thread, I incorrectly said the problem was with "Meson
> animals". The Meson side is fine, and both alligator and bushmaster
> use Autoconf, so I'm not sure how I ended up with that idea.)
>
> v5-0002 should fix the more general buildfarm failure that caused the
> revert. The farm finds the new t/ subdirectory and starts running Make
> on src/interfaces/libpq-oauth directly, bypassing the skip logic in
> src/interfaces/Makefile. So I've wrapped the "standard" top-level
> targets that build and install things in a conditional. The targets
> that clean things up have been left alone, at Tom's suggestion in [1].
>
> Thanks,
> --Jacob
>
> [1] https://postgr.es/m/CAOYmi%2Bm%3DxY0P_uAzAP_884uF-GhQ3wrineGwc9AEnb6fYxVqVQ%40mail.gmail.com
I don't think that's quite going to work. The buildfarm will now get a
"target not found" in the without-curl case, I suspect. I think you'll
need an alternative definition of the check target.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
view thread (25+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox