pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Platon Pronko <platon7pronko@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Subject: Re: very long record lines in expanded psql output
Date: Fri, 24 Sep 2021 07:49:32 +0300
Message-ID: <7bbc7e80-ca37-b601-9081-68d2e84b42af@gmail.com> (raw)
In-Reply-To: <15de79ff-b872-498f-8b9c-ced62f460936@dunslane.net>
References: <f03d38a3-db96-a56e-d1bc-dbbc80bbde4d@gmail.com>
	<CAFj8pRBJ8bcTga9qTYG_v25BfeCB=4+GNc1rbf94qex_3C_e-A@mail.gmail.com>
	<998a8549-f808-a349-bae6-9f44d07e050d@dunslane.net>
	<d5280c71-b11b-b0fc-f57d-5033a9197406@gmail.com>
	<bf64d7b0-413d-1501-00b2-992491b865b0@dunslane.net>
	<4e8b9a10-95aa-aecf-01a1-cbc24d643465@gmail.com>
	<66d23848-9f73-abc9-2fbb-3b8abfbb2fce@dunslane.net>
	<0efd52b9-450a-7636-fb75-663bc2d81b34@gmail.com>
	<92258bb8-8b9d-8f70-6f34-b5499215204c@dunslane.net>
	<aae2bfe7-e07f-bb11-5d5a-529e76e0f317@gmail.com>
	<7f3ef168-0958-a33d-6911-bda8999c30c2@gmail.com>
	<15de79ff-b872-498f-8b9c-ced62f460936@dunslane.net>

On 2021-09-23 22:28, Andrew Dunstan wrote:
>
> 2. It would possibly be better to pass the relevant parts of the options
> to print_aligned_vertical_line() rather than the whole options
> structure. It feels odd to pass both that and opt_border.

What do you think about doing it the other way around - passing only whole
options structure? That way we will roll 4 parameters (opt_border, printTextFormat,
and two xheader ones) into only one argument.
This increases code coupling a bit, but I'm not sure if that's relevant here.

Best regards,
Platon Pronko





view thread (39+ messages)  latest in thread

Message-ID: <7bbc7e80-ca37-b601-9081-68d2e84b42af@gmail.com>
Permalink:  ../7bbc7e80-ca37-b601-9081-68d2e84b42af@gmail.com/
Also on:    postgresql.org/message-id/7bbc7e80-ca37-b601-9081-68d2e84b42af@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: platon7pronko@gmail.com, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org, pryzby@telsasoft.com
  Subject: Re: very long record lines in expanded psql output
  In-Reply-To: <7bbc7e80-ca37-b601-9081-68d2e84b42af@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox