public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrei Zubkov <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Postgres hackers <[email protected]>
Cc: Drouvot, Bertrand <[email protected]>
Subject: Re: Normalization of utility queries in pg_stat_statements
Date: Mon, 06 Mar 2023 15:50:55 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<Y/[email protected]>
<Y/LcU/[email protected]>
<Y/7Y9U/y/[email protected]>
<[email protected]>
<[email protected]>
Hi Michael!
I'm rebasing a patch "Tracking statements entry timestamp in
pg_stat_statements" for applying after this patch. I've noted that
current tests are not quite independent one from another. There is two
statements in the end of user_activity.sql test:
DROP ROLE regress_stats_user1;
DROP ROLE regress_stats_user2;
Those are done after the last pg_stat_statements_reset call in this
test file and thus, those are included in checks of wal.out file:
query
| calls | rows | wal_bytes_generated | wal_records_generated |
wal_records_ge_rows
-----------------------------------------------------------------------
-------+-------+------+---------------------+-----------------------+--
-------------------
DELETE FROM pgss_wal_tab WHERE a > $1
| 1 | 1 | t | t | t
DROP ROLE regress_stats_user1
| 1 | 0 | t | t | t
DROP ROLE regress_stats_user2
| 1 | 0 | t | t | t
Those statements is not related to any WAL tests. It seems a little bit
incorrect to me.
Are we need some changes here?
--
Andrei Zubkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Normalization of utility queries in pg_stat_statements
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox