From: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add two missing tests in 035_standby_logical_decoding.pl
Date: Thu, 27 Apr 2023 12:54:30 +0200
Message-ID: <7f194571-5089-ae6f-4709-b56d35d7101f@gmail.com> (raw)
In-Reply-To: <CAA4eK1JHtfh6niGtpi5Mn-NMiFxrJSqRZQEzm9idGu52AQAAGQ@mail.gmail.com>
References: <20230426102751.pkfs7gwvvrgta6p3@alvherre.pgsql>
<19d8fa0d-e840-66eb-f5bc-4c3f9594ec8b@gmail.com>
<CAA4eK1JwbBLF=T+mgRTJG83A0D_+a--4D2LsLkC630O2Rj7WxQ@mail.gmail.com>
<274b31be-5833-f3ea-1da6-8afd50897ac4@gmail.com>
<CAA4eK1JHtfh6niGtpi5Mn-NMiFxrJSqRZQEzm9idGu52AQAAGQ@mail.gmail.com>
On 4/27/23 11:54 AM, Amit Kapila wrote:
> On Thu, Apr 27, 2023 at 1:05 PM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:
>>
>> On 4/27/23 5:37 AM, Amit Kapila wrote:
>>> On Wed, Apr 26, 2023 at 4:41 PM Drouvot, Bertrand
>>> <bertranddrouvot.pg@gmail.com> wrote:
>>>
>>> +When in recovery, the default value of target_lsn is $node->lsn('replay')
>>> +instead. This is needed when the publisher passed to
>>> wait_for_subscription_sync()
>>> +is a standby node.
>>>
>>> I think this will be useful whenever wait_for_catchup has been called
>>> for a standby node (where self is a standby node). I have tried even
>>> by commenting wait_for_subscription_sync in the new test then it fails
>>> for $node_standby->wait_for_catchup('tap_sub');. So instead, how about
>>> a comment like: "When in recovery, the default value of target_lsn is
>>> $node->lsn('replay') instead which ensures that the cascaded standby
>>> has caught up to what has been replayed on the standby."?
>>>
>>
>> I did it that way because wait_for_subscription_sync() was the first case I had
>> to work on but I do agree that your wording better describe the intend of the new
>> code.
>>
>> Changed in V7 attached.
>>
>
> Pushed.
>
Thanks!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bertranddrouvot.pg@gmail.com, amit.kapila16@gmail.com, alvherre@alvh.no-ip.org, vignesh21@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Add two missing tests in 035_standby_logical_decoding.pl
In-Reply-To: <7f194571-5089-ae6f-4709-b56d35d7101f@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox