agora inbox for [email protected]  

help / color / mirror / Atom feed

From: Antonin Houska <[email protected]>
To: Oleg Ivanov <[email protected]>
Cc: [email protected]
Subject: Re: [HACKERS] Proposal: generic WAL compression
Date: Mon, 20 Nov 2017 08:49:48 +0100
Message-ID: <8015.1511164188@localhost> (raw)
In-Reply-To: <23990.1510853483@localhost>
References: <[email protected]>
	<23990.1510853483@localhost>

Antonin Houska <[email protected]> wrote:

> Oleg Ivanov <[email protected]> wrote:
> 
> > In order to overcome that issue, I would like to propose the patch, which
> > provides possibility to use another approach of the WAL record
> > construction.
> 
> After having spent several hours reviewing this patch I dare to send the
> following comments:

One more idea:

I think the metadata (ALIGN_GAP) should be stored separate from the actual
data so that you can use memcpy() instead of this loop:

    while (i < j)
    {
	    char		c = targetRegionAligned[i++];

	    writeToPtr(ptr, c);
    }


-- 
Antonin Houska
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt
Web: http://www.postgresql-support.de, http://www.cybertec.at

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [HACKERS] Proposal: generic WAL compression
  In-Reply-To: <8015.1511164188@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox