From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Cc: pgsql@j-davis.com
Subject: Re: Decision by Monday: PQescapeString() vs. encoding violation
Date: Sat, 15 Feb 2025 13:35:10 -0500
Message-ID: <80374.1739644510@sss.pgh.pa.us> (raw)
In-Reply-To: <7vmfuavitlhjgruidll67y5cd4s3m66m4x7c4yxezkxlo4dxvv@4haeja2xdn2q>
References: <20250215012712.45@rfd.leadboat.com>
<f9e447e5-d94f-45f0-8ccb-2570cd4419c9@dunslane.net>
<77190.1739642883@sss.pgh.pa.us>
<7vmfuavitlhjgruidll67y5cd4s3m66m4x7c4yxezkxlo4dxvv@4haeja2xdn2q>
Andres Freund <andres@anarazel.de> writes:
> It seems that nobody is arguing against the "just skip one byte" behaviour, so
> I'm inclined to push this fairly soon, even if Noah's "24 hours" haven't quite
> elapsed. A few more cycles in the buildfarm wouldn't hurt.
Agreed. I thought there would be more discussion, but it seems
nobody really objects to changing this.
The other thing that was discussed in the security thread was
modifying PQescapeStringInternal and PQescapeInternal to produce
no more than one complaint about invalid multibyte characters,
on the grounds that input that's just plain in some other encoding
would otherwise produce a ton of repetitive messages. That seems
trivial enough to mechanize with a bool already_complained flag,
so I think we should incorporate that refinement while we're here.
I can write that patch if you're busy.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, andrew@dunslane.net, noah@leadboat.com, pgsql@j-davis.com
Subject: Re: Decision by Monday: PQescapeString() vs. encoding violation
In-Reply-To: <80374.1739644510@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox