public inbox for [email protected]  

help / color / mirror / Atom feed
From: Chao Li <[email protected]>
To: Laurenz Albe <[email protected]>
Cc: Shinya Kato <[email protected]>
Cc: Michael Banck <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: [email protected]
Subject: Re: Set log_lock_waits=on by default
Date: Mon, 8 Sep 2025 10:38:07 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<20240206165343.GA3841415@nathanxps13>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAOzEurS0jbDrjmVFgE4QQ_O0bnDtJMaaFsy3=pX0RLYXBcjVpg@mail.gmail.com>
	<[email protected]>



> On Sep 8, 2025, at 05:46, Laurenz Albe <[email protected]> wrote:
> 
> On Thu, 2025-09-04 at 14:12 +0900, Shinya Kato wrote:
>> Due to 635998965 [0], you need to change guc_parameters.dat instead of
>> guc_tables.c.
> 
> Thanks for pointing that out to me!
> Here is an updated patch.
> 
> Yours,
> Laurenz Albe
> <v2-0001-Default-to-log_lock_waits-on.patch>


I am hesitate to support this change. I agree log_lock_waits is a powerful tool, but it’s more like a diagnostic tool. On a high-concurrency system with many tractions running at the same time, it may quickly fill up log files and make it difficult to find other errors. So, we usually only turn it on when needed, and turn it off once debugging is done.

But v2 code looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/






view thread (15+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Set log_lock_waits=on by default
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox