From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ICU integration
Date: Thu, 9 Feb 2017 10:58:21 -0500
Message-ID: <8149a3ad-c3bb-4e5e-db01-2cfe533144b2@2ndquadrant.com> (raw)
In-Reply-To: <6ee64972-fc4d-b169-7f25-0940118f59ce@2ndquadrant.com>
References: <85364fde-091f-bbc0-fec2-e3ede39840a6@2ndquadrant.com>
<3a88fa29-275b-f547-9957-86d4b2cd68db@2ndquadrant.com>
<CAM3SWZT6YFtkkjUOGgzBV9_tMijz+s68YgDZi7Qc2sPdFnQ9Bw@mail.gmail.com>
<6ee64972-fc4d-b169-7f25-0940118f59ce@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 1/24/17 12:45 PM, Peter Eisentraut wrote:
> On 1/9/17 3:45 PM, Peter Geoghegan wrote:
>> * I think it's worth looking into ucol_nextSortKeyPart(), and using
>> that as an alternative to ucol_getSortKey(). It doesn't seem any
>> harder, and when I tested it it was clearly faster. (I think that
>> ucol_nextSortKeyPart() is more or less intended to be used for
>> abbreviated keys.)
> I will try to look into that.
I think I have this sorted out. What I don't understand, however, is
why varstr_abbrev_convert() makes a point of looping until the result of
strxfrm() fits into the output buffer (buf2), when we only need 8 bytes,
and we throw away the rest later. Wouldn't it work to just request 8 bytes?
If there is a problem with just requesting 8 bytes, then I'm wondering
how this would affect the ICU code branch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, pg@bowt.ie
Subject: Re: ICU integration
In-Reply-To: <8149a3ad-c3bb-4e5e-db01-2cfe533144b2@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox