pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Thomas Munro <thomas.munro@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Cleaning up historical portability baggage
Date: Fri, 12 Aug 2022 09:15:55 +0200
Message-ID: <81bb50ca-d0ea-8cb2-7453-a5058a7b49a8@enterprisedb.com> (raw)
In-Reply-To: <CA+hUKG+L_3brvh=8e0BW_VfX9h7MtwgN=nFHP5o7X2oZucY9dg@mail.gmail.com>
References: <CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com>
	<CA+Tgmoazusui5EoU_7Z=AgwC5pTAqDndTa7d-owjvQwG3zoRhg@mail.gmail.com>
	<CA+hUKGLLJUMDgCzOK5K4NE6PpU87Ka7t7RQsZoZAZ_EKfL5L+A@mail.gmail.com>
	<CA+Tgmoaw6VBC9Xzr4vOaC0kc-94jb9nzH8MY38Gqn7=wy=i_3w@mail.gmail.com>
	<20220712173352.trdeq66asbv6vf2q@awork3.anarazel.de>
	<1662559.1657648462@sss.pgh.pa.us>
	<CA+hUKG+MOzmDkr27ceG8+uwgFxbJUUv699V3VP3DCioQigrf7A@mail.gmail.com>
	<1249825.1658622186@sss.pgh.pa.us>
	<CA+hUKGLryBW4fNYoXzMG9y1e0H-QOTdSiTG46xCr1DNuuPwbeg@mail.gmail.com>
	<CA+hUKGJMcwbzRyfTocfxbPBUhERqKE42d-L22jQ+vpB7an-NjQ@mail.gmail.com>
	<20220804034343.unm4rdynedbigamv@awork3.anarazel.de>
	<3322724.1659586159@sss.pgh.pa.us>
	<CA+hUKGJ5ej33AJL19sQph7Z8SFZ6+aUSKxFTS6pvk2Y8J9Tcwg@mail.gmail.com>
	<295419.1659918447@sss.pgh.pa.us>
	<CA+hUKGK=N8W2uFPdJr07Rs4dgRtbzKaYvCaPQasX3S8=aTO5PQ@mail.gmail.com>
	<747620.1660002360@sss.pgh.pa.us>
	<CA+hUKG+L_3brvh=8e0BW_VfX9h7MtwgN=nFHP5o7X2oZucY9dg@mail.gmail.com>

On 11.08.22 12:02, Thomas Munro wrote:
>   * The concept of a no-Unix-socket build is removed.  We should be
> able to do that now, right?  Peter E seemed to say approximately that
> in the commit message for 797129e5.  Or is there a thought that a new
> operating system might show up that doesn't have 'em and we'd wish
> we'd kept this stuff well marked out?

Most uses of HAVE_UNIX_SOCKETS are not useful independent of that 
question.  For example, you patch has

@@ -348,7 +343,6 @@ StreamServerPort(int family, const char *hostName, 
unsigned short portNumber,
  	hint.ai_flags = AI_PASSIVE;
  	hint.ai_socktype = SOCK_STREAM;

-#ifdef HAVE_UNIX_SOCKETS
  	if (family == AF_UNIX)
  	{
  		/*

But on a platform without support for Unix sockets, family just won't be 
AF_UNIX at run time, so there is no need to hide that if branch.

Note that we already require that AF_UNIX is defined on all platforms, 
even if the kernel doesn't support Unix sockets.

But maybe it would be better to make that a separate patch from the 
sys/un.h configure changes, just so there is more clarity around it.





view thread (108+ messages)  latest in thread

Message-ID: <81bb50ca-d0ea-8cb2-7453-a5058a7b49a8@enterprisedb.com>
Permalink:  ../81bb50ca-d0ea-8cb2-7453-a5058a7b49a8@enterprisedb.com/
Also on:    postgresql.org/message-id/81bb50ca-d0ea-8cb2-7453-a5058a7b49a8@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, andres@anarazel.de, andrew@dunslane.net, robertmhaas@gmail.com
  Subject: Re: Cleaning up historical portability baggage
  In-Reply-To: <81bb50ca-d0ea-8cb2-7453-a5058a7b49a8@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox