pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Alexander Lakhin <exclusion@gmail.com>
To: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: vignesh C <vignesh21@gmail.com>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: Yura Sokolov <y.sokolov@postgrespro.ru>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: refactoring relation extension and BufferAlloc(), faster COPY
Date: Wed, 12 Apr 2023 08:00:00 +0300
Message-ID: <8204503e-1c75-9d3c-8b4f-30af42a0aee0@gmail.com> (raw)
In-Reply-To: <20230411232103.ycmsxs6bmtllmjki@awork3.anarazel.de>
References: <CAAKRu_aW2SX_LWtwHgfnqYpBrunMLfE9PD6-ioPpkh92XH0qpg@mail.gmail.com>
	<20230329034754.elzpfwacqmapv6pj@awork3.anarazel.de>
	<CAAKRu_Z_oetHcv37trJxaZv2N-vA4Z6Hoaq1PRnRL9M68EXtKw@mail.gmail.com>
	<20230330010342.rxyr5wm6szkt42wq@awork3.anarazel.de>
	<20230330030233.j7wsqcsvptnsniuc@awork3.anarazel.de>
	<20230405003945.77fsb4ct47xqoglc@awork3.anarazel.de>
	<20230406014616.rceit67ndlsqpnx3@awork3.anarazel.de>
	<20230407011514.mhffy3veft6pwhr4@awork3.anarazel.de>
	<20230407083911.qhjl3am6qh7vyi5l@awork3.anarazel.de>
	<0b5eb82b-cb99-e0a4-b932-3dc60e2e3926@gmail.com>
	<20230411232103.ycmsxs6bmtllmjki@awork3.anarazel.de>

12.04.2023 02:21, Andres Freund wrote:
> Hi,
>
> On 2023-04-11 22:00:00 +0300, Alexander Lakhin wrote:
>> A few days later I've found a new defect introduced with 31966b151.
> That's the same issue that Tom also just reported, at
> https://postgr.es/m/392271.1681238924%40sss.pgh.pa.us
>
> Attached is my WIP fix, including a test.

Thanks for the fix. I can confirm that the issue is gone.
ReadBuffer_common() contains an Assert(), that is similar to the fixed one,
but it looks unreachable for the WAL replay case after 26158b852.

Best regards,
Alexander

view thread (57+ messages)  latest in thread

Message-ID: <8204503e-1c75-9d3c-8b4f-30af42a0aee0@gmail.com>
Permalink:  ../8204503e-1c75-9d3c-8b4f-30af42a0aee0@gmail.com/
Also on:    postgresql.org/message-id/8204503e-1c75-9d3c-8b4f-30af42a0aee0@gmail.com

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: exclusion@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, melanieplageman@gmail.com, horikyota.ntt@gmail.com, hlinnaka@iki.fi, alvherre@alvh.no-ip.org, vignesh21@gmail.com, thomas.munro@gmail.com, y.sokolov@postgrespro.ru, robertmhaas@gmail.com
  Subject: Re: refactoring relation extension and BufferAlloc(), faster COPY
  In-Reply-To: <8204503e-1c75-9d3c-8b4f-30af42a0aee0@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox