From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Mark Dilger <hornschnorter@gmail.com>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: WIP: BRIN multi-range indexes
Date: Tue, 23 Jan 2018 22:07:22 +0100
Message-ID: <821c4c1d-592e-8916-e323-04607b11777e@2ndquadrant.com> (raw)
In-Reply-To: <20180123200537.gfx5hxcp5k5hktpe@alvherre.pgsql>
References: <20180123200537.gfx5hxcp5k5hktpe@alvherre.pgsql>
On 01/23/2018 09:05 PM, Alvaro Herrera wrote:
> This stuff sounds pretty nice. However, have a look at this report:
>
> https://codecov.io/gh/postgresql-cfbot/postgresql/commit/2aa632dae3066900e15d2d42a4aad811dec11f08
>
> it seems to me that the new code is not tested at all. Shouldn't you
> add a few more tests?
>
I have a hard time reading the report, but you're right I haven't added
any tests for the new opclasses (bloom and minmax_multi). I agree that's
something that needs to be addressed.
> I think 0004 should apply to unpatched master (except for the parts
> that concern files not in master); sounds like a good candidate for
> first apply. Then 0001, which seems mostly just refactoring. 0002 and
> 0003 are the really interesting ones (minus the code removed by
> 0004).
>
That sounds like a reasonable plan. I'll reorder the patch series along
those lines in the next few days.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, alvherre@alvh.no-ip.org, hornschnorter@gmail.com
Subject: Re: WIP: BRIN multi-range indexes
In-Reply-To: <821c4c1d-592e-8916-e323-04607b11777e@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox