pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Alexander Lakhin <exclusion@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: prevent immature WAL streaming
Date: Mon, 8 Nov 2021 07:00:00 +0300
Message-ID: <83641f59-d566-b33e-ef21-a272a98675aa@gmail.com> (raw )
In-Reply-To: <202110132209.uyw4ubpc2ztc@alvherre.pgsql >
References: <202110132209.uyw4ubpc2ztc@alvherre.pgsql >
Hello Alvaro,
14.10.2021 01:09, Alvaro Herrera wrote:
>> Yea, let's go for your patch then. I've verified that at least locally it
>> passes under valgrind.
> Ah great, thanks. Pushed then.
>
While translating messages I've noticed that the version of the patch
ported to REL9_6_STABLE..REL_13_STABLE contains a typo "sucessfully".
Please consider committing the fix.
Best regards,
Alexander
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 6d37b82330d..3d76fad1282 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -10383,7 +10383,7 @@ VerifyOverwriteContrecord(xl_overwrite_contrecord *xlrec, XLogReaderState *state
(uint32) state->overwrittenRecPtr);
ereport(LOG,
- (errmsg("sucessfully skipped missing contrecord at %X/%X, overwritten at %s",
+ (errmsg("successfully skipped missing contrecord at %X/%X, overwritten at %s",
(uint32) (xlrec->overwritten_lsn >> 32),
(uint32) xlrec->overwritten_lsn,
timestamptz_to_str(xlrec->overwrite_time))));
diff --git a/src/test/recovery/t/026_overwrite_contrecord.pl b/src/test/recovery/t/026_overwrite_contrecord.pl
index c35e3717276..4fac44e2617 100644
--- a/src/test/recovery/t/026_overwrite_contrecord.pl
+++ b/src/test/recovery/t/026_overwrite_contrecord.pl
@@ -94,7 +94,7 @@ ok($node_standby->safe_psql('postgres', 'select * from foo') eq 'hello',
my $log = slurp_file($node_standby->logfile);
like(
$log,
- qr[sucessfully skipped missing contrecord at],
+ qr[successfully skipped missing contrecord at],
"found log line in standby");
$node->stop;
Attachments:
[text/plain] fix-sucessfully,patch (1.2K, ../83641f59-d566-b33e-ef21-a272a98675aa@gmail.com/2-fix-sucessfully%2Cpatch)
download | inline diff:
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 6d37b82330d..3d76fad1282 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -10383,7 +10383,7 @@ VerifyOverwriteContrecord(xl_overwrite_contrecord *xlrec, XLogReaderState *state
(uint32) state->overwrittenRecPtr);
ereport(LOG,
- (errmsg("sucessfully skipped missing contrecord at %X/%X, overwritten at %s",
+ (errmsg("successfully skipped missing contrecord at %X/%X, overwritten at %s",
(uint32) (xlrec->overwritten_lsn >> 32),
(uint32) xlrec->overwritten_lsn,
timestamptz_to_str(xlrec->overwrite_time))));
diff --git a/src/test/recovery/t/026_overwrite_contrecord.pl b/src/test/recovery/t/026_overwrite_contrecord.pl
index c35e3717276..4fac44e2617 100644
--- a/src/test/recovery/t/026_overwrite_contrecord.pl
+++ b/src/test/recovery/t/026_overwrite_contrecord.pl
@@ -94,7 +94,7 @@ ok($node_standby->safe_psql('postgres', 'select * from foo') eq 'hello',
my $log = slurp_file($node_standby->logfile);
like(
$log,
- qr[sucessfully skipped missing contrecord at],
+ qr[successfully skipped missing contrecord at],
"found log line in standby");
$node->stop;
view thread (121+ messages) latest in thread
Message-ID: <83641f59-d566-b33e-ef21-a272a98675aa@gmail.com>
Permalink: ../83641f59-d566-b33e-ef21-a272a98675aa@gmail.com/
Also on: postgresql.org/message-id/83641f59-d566-b33e-ef21-a272a98675aa@gmail.com
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: exclusion@gmail.com, alvherre@alvh.no-ip.org, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: prevent immature WAL streaming
In-Reply-To: <83641f59-d566-b33e-ef21-a272a98675aa@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox