pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Emit a warning if the extension's GUC is set incorrectly
Date: Fri, 17 Dec 2021 07:42:58 +0100
Message-ID: <83b33009-3a1b-9230-8f07-2115763c1853@enterprisedb.com> (raw)
In-Reply-To: <9f5e96ca44891915f1d2736bea9fdf45@oss.nttdata.com>
References: <524fa2c0a34f34b68fbfa90d0760d515@oss.nttdata.com>
	<681A95E0-0CCA-4C66-A12B-CE0D8D5076D7@yesql.se>
	<25643eaa81a69416317e85c2fd7d4c0a@oss.nttdata.com>
	<CALj2ACX9eDm9bPmcZDTGazEVrH+p7jUXfN0miBc_VVze_mjw9A@mail.gmail.com>
	<98d354d3b099d8e24c6b653336bd29d7@oss.nttdata.com>
	<CALj2ACUBKmDa35PmcfGZ==4rLNm4GW04D7o-ARkeipHijr5yuw@mail.gmail.com>
	<4a2c5e69b98bf8ffbef2fad2f1850c97@oss.nttdata.com>
	<9956b3b9-9cc3-49d2-f9e8-7f3ed3c63994@oss.nttdata.com>
	<9f5e96ca44891915f1d2736bea9fdf45@oss.nttdata.com>

On 17.12.21 03:25, Shinya Kato wrote:
> For now, I'v attached the patch that fixed the compilation error.

I think it would be good if you could split the uncontroversial new 
EmitErrorsOnPlaceholders() calls into a separate patch.  And please add 
an explanation what exactly the rest of the patch changes.





view thread (24+ messages)  latest in thread

Message-ID: <83b33009-3a1b-9230-8f07-2115763c1853@enterprisedb.com>
Permalink:  ../83b33009-3a1b-9230-8f07-2115763c1853@enterprisedb.com/
Also on:    postgresql.org/message-id/83b33009-3a1b-9230-8f07-2115763c1853@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, Shinya11.Kato@oss.nttdata.com, masao.fujii@oss.nttdata.com, bharath.rupireddyforpostgres@gmail.com, daniel@yesql.se
  Subject: Re: Emit a warning if the extension's GUC is set incorrectly
  In-Reply-To: <83b33009-3a1b-9230-8f07-2115763c1853@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox