From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Joe Conway <mail@joeconway.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: David Steele <david@pgmasters.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Nico Williams <nico@cryptonector.com>
Cc: Robbie Harwood <rharwood@redhat.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v20] GSSAPI encryption support
Date: Fri, 12 Apr 2019 10:22:03 +0200
Message-ID: <8416d227-6e9d-092a-4475-b453e1d7d433@2ndquadrant.com> (raw)
In-Reply-To: <5bd413ae-719d-4db4-b25a-346f22054930@2ndquadrant.com>
References: <20190405025925.GN6197@tamriel.snowman.net>
<7d0584ab-26a8-6731-aeee-9c8e195533e6@2ndquadrant.com>
<20190405124803.GO6197@tamriel.snowman.net>
<f56cacac-0693-23aa-353d-179adbe32f2e@2ndquadrant.com>
<20190405213745.GR6197@tamriel.snowman.net>
<160445e8-2ccf-7ffd-728f-80597c248a57@2ndquadrant.com>
<20190409025114.GW6197@tamriel.snowman.net>
<5bd413ae-719d-4db4-b25a-346f22054930@2ndquadrant.com>
On 2019-04-09 09:32, Peter Eisentraut wrote:
> On 2019-04-09 04:51, Stephen Frost wrote:
>>> Running just 002_enc.pl by itself passes the tests!
>> Great! I think what I'll do is work to incorporate the two tests back
>> into one script, to avoid whatever the race condition or other confusion
>> is happening on macOS here.
>
> That seems reasonable. It also avoids the large amount of duplicate
> setup code.
Another problem is that the two test files cannot be run in parallel
because they use the same hardcoded data directories. That would have
to be replaced by temporary directories.
The race condition alluded to above appears to be simply that at the end
of the test the kdc is shut down by kill -INT but nothing waits for that
to finish before a new one is started by the next test. So there is
potential for all kinds of confusion.
Putting it all in one test file seems to be the easiest way out.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, sfrost@snowman.net, magnus@hagander.net, mail@joeconway.com, alvherre@2ndquadrant.com, david@pgmasters.net, michael@paquier.xyz, nico@cryptonector.com, rharwood@redhat.com
Subject: Re: [PATCH v20] GSSAPI encryption support
In-Reply-To: <8416d227-6e9d-092a-4475-b453e1d7d433@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox