From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jesse Zhang <sbjesse@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Residual cpluspluscheck issues
Date: Wed, 30 Sep 2020 11:47:18 -0400
Message-ID: <844760.1601480838@sss.pgh.pa.us> (raw)
In-Reply-To: <CAGf+fX5W2JwS3c0DW+c=tnmoCGEs5tvKNYMQZ+DV2XaLWAJ81g@mail.gmail.com>
References: <20518.1559494394@sss.pgh.pa.us>
<CAGf+fX5W2JwS3c0DW+c=tnmoCGEs5tvKNYMQZ+DV2XaLWAJ81g@mail.gmail.com>
Jesse Zhang <sbjesse@gmail.com> writes:
> So it's been 17 months since you sent this email, so I'm not sure that
> nothing has happened (off list or in the code base), but...
Well, we fixed the case that was discussed at the time [1].
I'm not exactly convinced about removing the register keywords in
s_lock.h. Those are all associated with asm blocks, which are already
extremely C/GCC specific; complaining that the register declarations
aren't portable seems to be missing the forest for the trees.
BTW, grepping my local tree says that plperl/ppport.h also has some
register variables, which is something we have no control over.
regards, tom lane
[1] https://git.postgresql.org/gitweb/?p=postgresql.git&a=commitdiff&h=232720be9
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, sbjesse@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Residual cpluspluscheck issues
In-Reply-To: <844760.1601480838@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox