pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: andres@anarazel.de
Cc: tgl@sss.pgh.pa.us
Cc: michael@paquier.xyz
Cc: pgsql-hackers@postgresql.org
Subject: Re: ALTER TABLE on system catalogs
Date: Thu, 14 Feb 2019 16:35:45 +0100
Message-ID: <84c6bcc4-026f-a44f-5726-e8035f4d197a@2ndquadrant.com> (raw)
In-Reply-To: <20190208.120444.251121059.horiguchi.kyotaro@lab.ntt.co.jp>
References: <a33f9d7f-4afe-a351-3528-cc32b0603845@2ndquadrant.com>
	<20180821152444.4reji5otfekmvtoc@alap3.anarazel.de>
	<61666008-d1cd-7a66-33c8-215449f5d1b0@2ndquadrant.com>
	<20190208.120444.251121059.horiguchi.kyotaro@lab.ntt.co.jp>

On 08/02/2019 04:04, Kyotaro HORIGUCHI wrote:
> By the way, I'm confused to see that attributes that don't want
> to go external are marked as 'x' in system catalogs. Currently
> (putting aside its necessity) the following operation ends with
> successful attaching a new TOAST relation, which we really don't
> want.
> 
> ALTER TABLE pg_attribute ALTER COLUMN attrelid SET STORAGE plain;
> 
> Might be silly, but couldn't we have another storage class? Say,
> Compression, which means try compress but don't go external.

That already exists: 'm': Value can be stored compressed inline

I agree that it seems we should be using that for those tables that
don't have a toast table.  Maybe the genbki stuff could do it
automatically for the appropriate catalogs.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (25+ messages)  latest in thread

Message-ID: <84c6bcc4-026f-a44f-5726-e8035f4d197a@2ndquadrant.com>
Permalink:  ../84c6bcc4-026f-a44f-5726-e8035f4d197a@2ndquadrant.com/
Also on:    postgresql.org/message-id/84c6bcc4-026f-a44f-5726-e8035f4d197a@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, horiguchi.kyotaro@lab.ntt.co.jp, andres@anarazel.de, tgl@sss.pgh.pa.us, michael@paquier.xyz
  Subject: Re: ALTER TABLE on system catalogs
  In-Reply-To: <84c6bcc4-026f-a44f-5726-e8035f4d197a@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox