pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_dump versus ancient server versions
Date: Mon, 13 Dec 2021 12:23:10 -0500
Message-ID: <853517.1639416190@sss.pgh.pa.us> (raw)
In-Reply-To: <70194.1639290264@sss.pgh.pa.us>
References: <CA+TgmoboH6=SgWHPddv_8ie91Qf2ECKSvg-72aYajKb2gyLYQg@mail.gmail.com>
	<202110222351.3f42l5fgo3lw@alvherre.pgsql>
	<CA+TgmobB8cj30z6dzEf5xNTxzGRNGmkJsCr3nv_Hneo0o5kozg@mail.gmail.com>
	<3783090.1635111977@sss.pgh.pa.us>
	<CA+TgmobQxeGVtgxQz_OxdgCO4r=Tb2SaCh9FJ8Dxjaq9DxHH_g@mail.gmail.com>
	<3883429.1635171820@sss.pgh.pa.us>
	<20211025170657.ekufa7urdcyzpgdm@alap3.anarazel.de>
	<c51ede27-3b6d-1d27-9d1a-227526858db2@dunslane.net>
	<22018.1635202338@sss.pgh.pa.us>
	<d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com>
	<20211202221607.xovsdnoh5tpbnhbs@alap3.anarazel.de>
	<196b40be-c571-e77f-3335-920f8a00047f@enterprisedb.com>
	<2316211.1638556231@sss.pgh.pa.us>
	<CA+Tgmob0V3dJ57vKL1iouk1oLMFn-60eAUQ+ab6=1BDG7ZC8iw@mail.gmail.com>
	<2978297.1638751274@sss.pgh.pa.us>
	<3794414.1639072240@sss.pgh.pa.us>
	<6f92dea3-9619-be68-239f-8990a832b453@dunslane.net>
	<70194.1639290264@sss.pgh.pa.us>

I wrote:
> Anyway, it seems like there's some consensus that 9.2 is a good
> stopping place for today.  I'll push forward with
> (1) back-patching as necessary to make 9.2 and up build cleanly
> on the platforms I have handy;

I've done as much as I plan to do in that direction.  As of the
respective branch tips, I see clean builds and check-world
results with minimal configure options in all branches back to 9.2
on Fedora 35 (gcc 11.2.1) and macOS Monterey (Apple clang 13.0.0).

A few notes for the archives' sake:

* As discussed, parallel check-world is unreliable before v10;
perhaps this is worth improving, but I doubt it.  I did find
that aggressive parallelism in the build process is fine.

* On some compilers, pre-v10 branches produce this warning:

scan.c: In function 'yy_try_NUL_trans':
scan.c:10189:23: warning: unused variable 'yyg' [-Wunused-variable]
     struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; /* This var may be unused depending upon options. */

In principle we could back-patch 65d508fd4 to silence that,
but I think that fix is more invasive than what we want to
do in these branches.  We lived with that warning for years
before figuring out how to get rid of it, so I think we can
continue to accept it in these branches.

* 9.2's plperl fails to compile on macOS:

./plperl.h:53:10: fatal error: 'EXTERN.h' file not found
#include "EXTERN.h"

This is evidently because 9.2 predates the "sysroot" hacking
we did later (5e2217131 and many many subsequent tweaks).
I judge this not worth the trouble to fix, because the argument
for supporting --with-perl in these branches is basically that
we need a PL with transforms to test pg_dump ... but transforms
didn't come in until 9.5.  (Reviewing the commit log, I suppose
that 9.3 and 9.4 would also fail to build in some macOS
configurations, but by the same argument I see no need to work
further on those branches either.  9.5 does have all the
sysroot changes I can find in the log.)

			regards, tom lane





view thread (70+ messages)  latest in thread

Message-ID: <853517.1639416190@sss.pgh.pa.us>
Permalink:  ../853517.1639416190@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/853517.1639416190@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, andrew@dunslane.net, andres@anarazel.de, robertmhaas@gmail.com, bruce@momjian.us, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_dump versus ancient server versions
  In-Reply-To: <853517.1639416190@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox