pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: michael@paquier.xyz
Cc: thomas.munro@gmail.com
Cc: tomas.vondra@2ndquadrant.com
Cc: a.zakirov@postgrespro.ru
Cc: ah@cybertec.at
Cc: magnus@hagander.net
Cc: robertmhaas@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: shared-memory based stats collector
Date: Mon, 09 Mar 2020 15:04:23 -0400
Message-ID: <8668.1583780663@sss.pgh.pa.us> (raw)
In-Reply-To: <20200309184754.yvrgzqpzs3iynszq@alap3.anarazel.de>
References: <15888.1583770875@sss.pgh.pa.us>
<20200309183705.GA10363@alvherre.pgsql>
<20200309184754.yvrgzqpzs3iynszq@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2020-03-09 15:37:05 -0300, Alvaro Herrera wrote:
>> I'm worried that we're causing all processes to terminate when an
>> archiver dies in some ugly way; but in the current coding, it's pretty
>> harmless and we'd just start a new one. I think this needs to be
>> reconsidered. As far as I know, pgarchiver remains unconnected to
>> shared memory so a crash-restart cycle is not necessary. We should
>> continue to just log the error message and move on.
> Why is it worth having the archiver be "robust" that way?
I'd ask a different question: what the heck is this patchset doing
touching the archiver in the first place? I can see no plausible
reason for that doing anything related to stats collection. If we
now need some new background processing for stats, let's make a
new postmaster child process to do that, not overload the archiver
with unrelated responsibilities.
regards, tom lane
view thread (238+ messages) latest in thread
Message-ID: <8668.1583780663@sss.pgh.pa.us>
Permalink: ../8668.1583780663@sss.pgh.pa.us/
Also on: postgresql.org/message-id/8668.1583780663@sss.pgh.pa.us
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, alvherre@2ndquadrant.com, horikyota.ntt@gmail.com, michael@paquier.xyz, thomas.munro@gmail.com, tomas.vondra@2ndquadrant.com, a.zakirov@postgrespro.ru, ah@cybertec.at, magnus@hagander.net, robertmhaas@gmail.com
Subject: Re: shared-memory based stats collector
In-Reply-To: <8668.1583780663@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox