From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Steven Pousty <steve.pousty@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Isaac Morland <isaac.morland@gmail.com>
Cc: Pierre Giraud <pierre.giraud@dalibo.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Poll: are people okay with function/operator table redesign?
Date: Wed, 29 Apr 2020 19:29:43 -0400
Message-ID: <8682.1588202983@sss.pgh.pa.us> (raw)
In-Reply-To: <30469.1588087170@sss.pgh.pa.us>
References: <20200423174343.GA16996@alvherre.pgsql>
<19233.1587665407@sss.pgh.pa.us>
<5561.1587922854@sss.pgh.pa.us>
<13e5e408-bc59-e8ca-44f3-28a981b4fc7d@postgresql.org>
<a47ea348-b9a0-02b7-5bcb-7a32143dd16f@postgresql.org>
<11211.1587951842@sss.pgh.pa.us>
<58de9544-be5b-f325-b5cc-cce4e2dda7d9@postgresql.org>
<5651.1587991781@sss.pgh.pa.us>
<b998a672-2525-1cba-ac64-b292f495919e@postgresql.org>
<30469.1588087170@sss.pgh.pa.us>
After further fooling with this issue, I've determined that
(1) I need to be able to use <programlisting> environments within the
func_table_entry cells and have them render more-or-less normally.
There doesn't seem to be any other good way to render multiline
example results for set-returning functions ... but marking such
environments up to the extent that the website style normally does
is very distracting.
(2) I found that adding !important to the func_table_entry rules
is enough to override less-general !important rules. So it'd be
possible to leave all the existing CSS rules alone, if that makes
you feel more comfortable.
The attached updated patch reflects both of these conclusions.
We could take out some of the !important annotations here if
you're willing to delete !important annotations in more-global
rules for <p> and/or <pre>, but maybe that's something to fool
with later. I'd like to get this done sooner ...
regards, tom lane
Attachments:website-style-2.patch (text/x-diff, 700B) download--- main.css.orig 2020-04-29 17:19:24.089511785 -0400+++ main.css 2020-04-29 19:18:28.082138095 -0400@@ -799,6 +799,27 @@
text-align: left;
}
+#docContent table.table th.func_table_entry p,+#docContent table.table td.func_table_entry p {+ margin-top: 0.1em;+ margin-bottom: 0.1em !important;+ padding-left: 4em;+ text-align: left;+}++#docContent table.table p.func_signature {+ text-indent: -3.5em;+}++#docContent table.table td.func_table_entry pre.programlisting {+ margin-top: 0.1em !important;+ margin-bottom: 0.1em !important;+ padding: 0 !important;+ padding-left: 4em !important;+ background-color: inherit !important;+ border: 0;+}+
/**
* Titles, Navigation
*/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, jkatz@postgresql.org, peter.eisentraut@2ndquadrant.com, bruce@momjian.us, alvherre@2ndquadrant.com, robertmhaas@gmail.com, steve.pousty@gmail.com, pavel.stehule@gmail.com, isaac.morland@gmail.com, pierre.giraud@dalibo.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Poll: are people okay with function/operator table redesign?
In-Reply-To: <8682.1588202983@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox