From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
Subject: Re: meson vs make: missing/inconsistent ENV
Date: Mon, 27 Feb 2023 12:30:59 +0000
Message-ID: <87a60zjnng.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <87edqbjr1i.fsf@wibble.ilmari.org>
References: <20230226225239.GL1653@telsasoft.com>
<20230226232104.5djexwyitlfemrhg@awork3.anarazel.de>
<20230227020029.GN1653@telsasoft.com>
<87edqbjr1i.fsf@wibble.ilmari.org>
Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> writes:
> Justin Pryzby <pryzby@telsasoft.com> writes:
>
>> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
>>> > Is there any consideration of promoting these or other warnings to
>>> > fatal?
>>>
>>> You mean the perl warnings?
>>
>> Yes - it'd be nice if the warnings caused an obvious failure to allow
>> addressing the issue. I noticed the icu warning while looking at a bug
>> in 0da243fed, and updating to add ZSTD.
>
> Perl warnings can be made fatal with `use warnings FATAL =>
> <categories>;`, but one should be careful about which categories to
> fatalise, per <https://metacpan.org/pod/warnings#Fatal-Warnings;.
>
> Some categories are inherently unsafe to fatalise, as documented in
> <https://metacpan.org/pod/strictures#CATEGORY-SELECTIONS;.
One disadvantage of making the warnings fatal is that it immediately
aborts the test. Another option would be to to turn warnings into test
failures, à la https://metacpan.org/pod/Test::Warnings or
https://metacpan.org/pod/Test::FailWarnings. Both those modules support
all the Perl versions we do, and have no non-core dependencies, but if
we don't want to add any more dependencies we can incorporate the logic
into one of our own testing modules.
- ilmari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, pryzby@telsasoft.com, andres@anarazel.de, peter@eisentraut.org
Subject: Re: meson vs make: missing/inconsistent ENV
In-Reply-To: <87a60zjnng.fsf@wibble.ilmari.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox