From: David Steele <david@pgmasters.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Retiring support for pre-7.3 FK constraint triggers
Date: Thu, 5 Mar 2020 09:56:40 -0500
Message-ID: <87bc3573-ea08-1da6-b119-bcba034e990f@pgmasters.net> (raw)
In-Reply-To: <1154.1583419325@sss.pgh.pa.us>
References: <20200305143041.GA7031@alvherre.pgsql>
<1154.1583419325@sss.pgh.pa.us>
On 3/5/20 9:42 AM, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> On 2020-Mar-05, Daniel Gustafsson wrote:
>>> While looking at the tg_updatedcols patch I happened to notice that we still
>>> support pre-7.3 constraint triggers by converting them on the fly. AFAICT this
>>> requires a pre-7.3 dump to hit.
>
>> I know it's a late in the cycle for patches in commitfest, but why not
>> consider this for pg13 nonetheless? It seems simple enough. Also, per
>> https://coverage.postgresql.org/src/backend/commands/trigger.c.gcov.html
>> this is the only large chunk of uncovered code in commands/trigger.c.
>
> +1 --- I think this fits in well with my nearby proposal to remove
> OPAQUE, which is also only relevant for pre-7.3 dumps. Let's just
> nuke that stuff.
+1. CF entry added:
https://commitfest.postgresql.org/27/2506
Regards,
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@pgmasters.net, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, daniel@yesql.se, pgsql-hackers@lists.postgresql.org
Subject: Re: Retiring support for pre-7.3 FK constraint triggers
In-Reply-To: <87bc3573-ea08-1da6-b119-bcba034e990f@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox