From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Shubham Khanna <khannashubham1197@gmail.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: Assorted typo fixes
Date: Wed, 03 Jan 2024 16:45:56 +0000
Message-ID: <87cyuimkl7.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <CA+Tgmob-0ybwZPMb=AEckTP9wna8Em-nPVW_VXPdqNOLwJs6dQ@mail.gmail.com>
References: <87le9fmi01.fsf@wibble.ilmari.org>
<CAHv8RjKqCANyFnXbCVoGz-OXVW30HO=KzbSvwmU67tfJTHn48g@mail.gmail.com>
<87frzgmz8b.fsf@wibble.ilmari.org>
<CA+Tgmob-0ybwZPMb=AEckTP9wna8Em-nPVW_VXPdqNOLwJs6dQ@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Jan 1, 2024 at 6:05 PM Dagfinn Ilmari Mannsåker
> <ilmari@ilmari.org> wrote:
>> Thanks. I've fixed the commit message (and elaborated it a bit more why
>> I think it's a valid and safe fix).
>
> Regarding 0001:
>
> - AIUI, check_decls.m4 is copied from an upstream project, so I don't
> think we should tinker with it.
It contains modified versions of a few macros from Autoconf's
general.m4¹, specifically _AC_UNDECLARED_WARNING (since renamed to
_AC_UNDECLARED_BUILTIN upstream) and _AC_CHECK_DECL_BODY. That has
since been updated² to spell François' name correctly, so I think we
should follow suit (and maybe also check if our override is even still
necessary).
[1]: http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=history;f=lib/autoconf/general.m4;hb=HEAD
[2]: http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=commitdiff;h=8a228e9d58363ad3ebdb89a05bd77568d1...> - I'm not convinced by encrypter->encryptor
> - I'm not convinced by multidimension-aware->multidimensional-aware
I don't feel particularly strongy about these.
> - I'm not convinced by cachable->cacheable
If nothing else, consistency. There are 13 occurrences of "cacheable"
and only three of "cachable" in the tree.
> - You corrected restorting to restarting, but I'm wondering if Andres
> intended restoring?
Yeah, re-reading the sentence that's clearly meant to be "restoring".
> Committed the rest of 0001.
>
> 0002-0005 look OK to me, so I committed those as well.
Thanks!
> With regard to 0006, we typically use indexes rather than indices as
> the plural of "index", although exceptions exist.
We (mostly) use indexes when referring to database indexes (as in btree,
gist, etc.), but indices when referring to offsets in arrays, which is
what this variable is about.
- ilmari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, robertmhaas@gmail.com, khannashubham1197@gmail.com, andres@anarazel.de
Subject: Re: Assorted typo fixes
In-Reply-To: <87cyuimkl7.fsf@wibble.ilmari.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox