From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Logging query parmeters in auto_explain
Date: Mon, 27 Jun 2022 12:27:57 +0100
Message-ID: <87fsjql51e.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <87iloml5a5.fsf@wibble.ilmari.org>
References: <87ee09mohb.fsf@wibble.ilmari.org>
<Yp8D4kb2qZnhNAWJ@paquier.xyz>
<8735ggn2lf.fsf@wibble.ilmari.org>
<YqFQbYkFLF4fXuZX@paquier.xyz>
<87tu8tla5s.fsf@wibble.ilmari.org>
<Yqg9tlxk0Ghwd7Of@paquier.xyz>
<87iloml5a5.fsf@wibble.ilmari.org>
Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> writes:
> Michael Paquier <michael@paquier.xyz> writes:
>
>> On Thu, Jun 09, 2022 at 11:55:11PM +0100, Dagfinn Ilmari Mannsåker wrote:
>>> Done (and more tests added), v3 attached.
>>
>> One thing I am wondering is if we'd better mention errdetail_params()
>> at the top of the initial check done in ExplainQueryParameters().
>> That's a minor issue, though.
>>
>> +sub query_log
>> +{
>> Perhaps a short description at the top of this routine to explain it
>> is worth it?
>
> Done. I also moved the function to the bottom of the file, to avoid
> distracting from the actual test queries.
I forgot to mention, I also changed the order of the query and
parameters, so that they can more naturally be left out when no changes
are needed.
- ilmari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: Logging query parmeters in auto_explain
In-Reply-To: <87fsjql51e.fsf@wibble.ilmari.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox