From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: Should contrib modules install .h files?
Date: Mon, 02 Jul 2018 16:11:07 +0100
Message-ID: <87h8lhoevw.fsf@news-spur.riddles.org.uk> (raw)
In-Reply-To: <63655.1530540982@sss.pgh.pa.us>
References: <87y3euomjh.fsf@news-spur.riddles.org.uk>
<ee05ea4c-3d5b-0ec6-8daa-3ec66f021076@2ndquadrant.com>
<87tvpinfr4.fsf@news-spur.riddles.org.uk>
<63444.1530537990@sss.pgh.pa.us>
<87lgatohzp.fsf@news-spur.riddles.org.uk>
<63655.1530540982@sss.pgh.pa.us>
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:
>> A slight snag in trying to use a subdir for each module is that
>> there is not in fact anywhere in the existing makefiles that uses or
>> assigns such a name. Indeed some contrib subdirs install multiple
>> modules.
Tom> So, given that we have to add something to the module makefiles
Tom> anyway, we could also add a macro specifying the subdirectory name
Tom> to use. (Although in practice this should always be equal to the
Tom> contrib/ subdirectory name, so maybe we could extract it on that
Tom> basis?)
Using the subdir name may work for in-tree contrib/ builds but it's not
so good for PGXS, which should not be making assumptions about the build
directory name.
How about this: it's most likely that modules that install include files
will also be using MODULE_big, so use that as the default name; if a
makefile that uses only MODULES also wants to install include files,
have it define MODULE_NAME (or some such variable) itself.
--
Andrew (irc:RhodiumToad)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@tao11.riddles.org.uk, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, andres@anarazel.de
Subject: Re: Should contrib modules install .h files?
In-Reply-To: <87h8lhoevw.fsf@news-spur.riddles.org.uk>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox