From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: perlcritic: prohibit map and grep in void conext
Date: Fri, 27 Aug 2021 11:32:30 +0100
Message-ID: <87mtp3uqip.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <YSiBz4jYfURTui3u@paquier.xyz>
References: <87fsvzhhc4.fsf@wibble.ilmari.org>
<8aa32735-a310-e5b9-cdd4-1282b72ae8f3@dunslane.net>
<8B793436-CB3B-469F-9034-DED161BB96B8@yesql.se>
<YSiBz4jYfURTui3u@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Jul 28, 2021 at 01:26:23PM +0200, Daniel Gustafsson wrote:
>> I'm fine with increasing this policy, but I don't have strong feelings. If we
>> feel the perlcritic policy change is too much, I would still prefer to go ahead
>> with the map rewrite part of the patch though.
>
> I have no issue either about the rewrite part of the patch, so I'd
> tend to just do this part and move on. Daniel, would you like to
> apply that?
Why the resistance to the perlcritic part? That one case is the only
violation in the tree today, and it's a pattern we don't want to let
back in (I will surely object every time I see it when reviewing
patches), so why not automate it?
- ilmari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, michael@paquier.xyz, daniel@yesql.se, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Subject: Re: perlcritic: prohibit map and grep in void conext
In-Reply-To: <87mtp3uqip.fsf@wibble.ilmari.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox