pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andy Fan <zhihuifan1213@163.com>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Japin Li <japinli@hotmail.com>
Cc: Jim Jones <jim.jones@uni-muenster.de>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: New function normal_rand_array function to contrib/tablefunc.
Date: Mon, 04 Nov 2024 00:51:41 +0000
Message-ID: <87ses7rfc2.fsf@163.com> (raw)
In-Reply-To: <CAEZATCVnsyJNG1FqyCKPkVmx0V6PO2Xz5KTwRR1EUcsTnBb=yQ@mail.gmail.com>
References: <87plssezpc.fsf@163.com>
	<fd1de8c0-467b-4a41-8f7b-0d5122676ecb@uni-muenster.de>
	<CAEZATCX_Rd24mS4ScEYV=cLKMoQEJX=+oq40kYbok8rw211W8g@mail.gmail.com>
	<87v814wmz0.fsf@163.com>
	<CAEZATCUMvnFMiYJbDvk4d1nDdZ8VEqZWOjTUUZZ3itowGyB42w@mail.gmail.com>
	<87plpv1rb0.fsf@163.com>
	<87le0iqrsu.fsf@163.com>
	<ME0P300MB04456793A234B3B1A2B77882B6942@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM>
	<87zfox2rx7.fsf@163.com>
	<ME0P300MB044589098B6FB20AA771C97DB6952@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM>
	<87ed68gcym.fsf@163.com>
	<CAEZATCXZt1sUuT4SdZo5vn1rJtm2Rp3UCUsH2YzyBt-vHRXrrQ@mail.gmail.com>
	<87ldyojxwg.fsf@163.com>
	<CAEZATCVnsyJNG1FqyCKPkVmx0V6PO2Xz5KTwRR1EUcsTnBb=yQ@mail.gmail.com>

Dean Rasheed <dean.a.rasheed@gmail.com> writes:

> On Wed, 16 Oct 2024 at 08:43, Andy Fan <zhihuifan1213@163.com> wrote:
>>
>>  Thanks for the detailed feedback! Here is the rebased version.
>>
>
> I took another look at this and I think it's in reasonable shape.
>
> I'm attaching an update, rebasing it on top of 9be4e5d293.

Thank you Dean. 

> Also it was missing a required update to the meson.build file --
> that's the immediate cause of the other cfbot failures.

OK, great to know this one, I should have paid more attention to cfbot. 

> The rest is just cosmetic tidying up, fixing indentation, tweaking
> comments, and the like. I also hacked on the docs a bit -- the
> synopsis only listed one of the new function signatures for some
> reason. After fixing that, I think it's sufficient to just list one
> usage example.

That looks better now, more concise and expressive sentences.

-- 
Best Regards
Andy Fan






view thread (30+ messages)  latest in thread

Message-ID: <87ses7rfc2.fsf@163.com>
Permalink:  ../87ses7rfc2.fsf@163.com/
Also on:    postgresql.org/message-id/87ses7rfc2.fsf@163.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: zhihuifan1213@163.com, dean.a.rasheed@gmail.com, japinli@hotmail.com, jim.jones@uni-muenster.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: New function normal_rand_array function to contrib/tablefunc.
  In-Reply-To: <87ses7rfc2.fsf@163.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox