From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Jim Jones <jim.jones@uni-muenster.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Adding argument names to aggregate functions
Date: Tue, 18 Apr 2023 11:27:54 +0100
Message-ID: <87sfcxv61h.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <d36e168b-7a07-e010-43c1-4a040ec1296c@uni-muenster.de>
References: <877cw3jl8y.fsf@wibble.ilmari.org>
<87wn2hq959.fsf@wibble.ilmari.org>
<16f35a27-ad65-0420-44ee-b41c3fd08aee@uni-muenster.de>
<87mt3ardbc.fsf@wibble.ilmari.org>
<54d1c9a9-6b16-2fb2-199e-ac903c88c4d2@uni-muenster.de>
<d36e168b-7a07-e010-43c1-4a040ec1296c@uni-muenster.de>
Jim Jones <jim.jones@uni-muenster.de> writes:
> On 18.04.23 10:58, I wrote:
>> On 14.04.23 12:03, Dagfinn Ilmari Mannsåker wrote:
>>> Thanks for the heads-up, here's a rebased patch. I've also formatted
>>> the lines to match what reformat_dat_file.pl wants. It also wanted to
>>> reformat a bunch of other entries, but I left those alone.
>>>
>>> - ilmari
>>
>> The patch applies cleanly now and \df shows the argument names:
>>
>> postgres=# \df string_agg
>> List of functions
>> Schema | Name | Result data type | Argument data
>> types | Type
>> ------------+------------+------------------+------------------------------+------
>> pg_catalog | string_agg | bytea | value bytea, delimiter bytea | agg
>> pg_catalog | string_agg | text | value text, delimiter text | agg
>> (2 rows)
>>
>> postgres=# \df json_object_agg
>> List of functions
>> Schema | Name | Result data type | Argument data
>> types | Type
>> ------------+-----------------+------------------+------------------------+------
>> pg_catalog | json_object_agg | json | key "any", value "any" | agg
>> (1 row)
>>
>>
>> I'm wondering if there are some sort of guidelines that dictate when
>> to name an argument or not. It would be nice to have one for future
>> reference.
I seemed to recall a patch to add arugment names to a bunch of functions
in the past, thinking that might have some guidance, but can't for the
life of me find it now.
>> I will mark the CF entry as "Read for Committer" and let the
>> committers decide if it's best to first create a guideline for that or
>> not.
>>
>> Best, Jim
>>
> I just saw that the patch is failing[1] on "macOS - Ventura -
> Meson". Not sure if it is related to this patch though ..
>
> [1]
> https://api.cirrus-ci.com/v1/artifact/task/5881376021413888/meson_log/build/meson-logs/meson-log.txt
Link to the actual job:
https://cirrus-ci.com/task/5881376021413888
The failure was:
[09:54:38.727] 216/262 postgresql:recovery / recovery/031_recovery_conflict ERROR 198.73s exit status 60
Looking at its log:
https://api.cirrus-ci.com/v1/artifact/task/5881376021413888/testrun/build/testrun/recovery/031_recov...
we see:
timed out waiting for match: (?^:User was holding a relation lock for too long) at /Users/admin/pgsql/src/test/recovery/t/031_recovery_conflict.pl line 311.
That looks indeed completely unrelated to this patch.
- ilmari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, jim.jones@uni-muenster.de
Subject: Re: Adding argument names to aggregate functions
In-Reply-To: <87sfcxv61h.fsf@wibble.ilmari.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox