From: Arseny Sher <a.sher@postgrespro.ru>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Alexander Lakhin <a.lakhin@postgrespro.ru>
Subject: Re: Too rigorous assert in reorderbuffer.c
Date: Tue, 12 Feb 2019 19:10:55 +0300
Message-ID: <87tvh9xa0g.fsf@ars-thinkpad> (raw)
In-Reply-To: <20190212135343.GA29518@alvherre.pgsql>
References: <20190211185003.GA27084@alvherre.pgsql>
<20190212135343.GA29518@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> I thought the blanket removal of the assert() was excessive, and we can
>> relax it instead; what do you think of the attached?
>
> More precisely, my question was: with this change, does the code still
> work correctly in your non-toy case?
Yes, it works. I thought for a moment that some obscure cases where cmax
on a single tuple is not strictly monotonic might exist, but looks like
they don't. So your change is ok for me, reshaping assert is better than
removing. make check is also good on all supported branches.
--
Arseny Sher
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.sher@postgrespro.ru, alvherre@2ndquadrant.com, a.lakhin@postgrespro.ru
Subject: Re: Too rigorous assert in reorderbuffer.c
In-Reply-To: <87tvh9xa0g.fsf@ars-thinkpad>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox