public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dagfinn Ilmari Mannsåker <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Japin Li <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: test_escape: invalid option -- 'c'
Date: Tue, 18 Feb 2025 13:11:11 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <ME0P300MB04451FB20CE0346A59C25CADB6FA2@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM>
<[email protected]>
Michael Paquier <[email protected]> writes:
> On Tue, Feb 18, 2025 at 11:12:13AM +0800, Japin Li wrote:
>> When I test test_escape, I find the usage of test_escape declares it
>> support -c option, however, when I use it, it complains it is an
>> invalid option.
>>
>> Here is a patch to fix it.
>
> You are right, obviously. The only reason why this is not showing up
> is that the TAP test uses the long option --conninfo.
This was something I did consider when porting the tests to use long
options: should we leave (or add) at least one usage of every
corresponding shor option, for exactly this reason?
> Speaking of which, this had better use fat commas to combine the
> option/value pairs in these commands.
I have a local branch which converts more of the tests to the long and
fat style, I'll try to finish that up for submission soon, and look at
adding/retaining coverage for short options.
- ilmari
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: test_escape: invalid option -- 'c'
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox