pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: torikoshia <torikoshia@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [doc] modifying unit from characters to bytes
Date: Wed, 8 Jul 2020 17:05:47 +0900
Message-ID: <88056e7e-24a8-3beb-590d-03adeeb52111@oss.nttdata.com> (raw)
In-Reply-To: <A96F46F3-65BB-4E1E-A423-8EE29729547F@yesql.se>
References: <cd5b49a5a14e887542f5f569c1c6bde2@oss.nttdata.com>
	<df4c5cef-2f69-ca3c-60e2-c784c404f02d@oss.nttdata.com>
	<A96F46F3-65BB-4E1E-A423-8EE29729547F@yesql.se>



On 2020/07/08 16:17, Daniel Gustafsson wrote:
>> On 8 Jul 2020, at 04:25, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> On 2020/07/08 10:54, torikoshia wrote:
>>> Hi,
>>> The manual describes the size of pg_stat_activity.query
>>> as below:
>>>   | By default the query text is truncated at 1024 characters;
>>> When considering multibyte characters, it seems more
>>> accurate to change the unit from "characters" to "bytes".
>>
>> Agreed. Barring any objection, I will commit this patch.
> 
> +1 to commit this patch, following the link to track_activity_query_size it's
> even specified to be bytes there.  IIRC the NULL terminator is also included in
> the 1024 bytes which prevents it from being 1024 characters even for
> non-multibyte.

Yes, so we should document "truncated at 1023 bytes" for accuracy, instead?
This might be more confusing for users, though....

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (7+ messages)  latest in thread

Message-ID: <88056e7e-24a8-3beb-590d-03adeeb52111@oss.nttdata.com>
Permalink:  ../88056e7e-24a8-3beb-590d-03adeeb52111@oss.nttdata.com/
Also on:    postgresql.org/message-id/88056e7e-24a8-3beb-590d-03adeeb52111@oss.nttdata.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, daniel@yesql.se, torikoshia@oss.nttdata.com
  Subject: Re: [doc] modifying unit from characters to bytes
  In-Reply-To: <88056e7e-24a8-3beb-590d-03adeeb52111@oss.nttdata.com>
  References: <cd5b49a5a14e887542f5f569c1c6bde2@oss.nttdata.com> <df4c5cef-2f69-ca3c-60e2-c784c404f02d@oss.nttdata.com> <A96F46F3-65BB-4E1E-A423-8EE29729547F@yesql.se> <88056e7e-24a8-3beb-590d-03adeeb52111@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox