From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: 001_rep_changes.pl stalls
Date: Mon, 13 Apr 2020 21:45:16 -0400
Message-ID: <8807.1586828716@sss.pgh.pa.us> (raw)
In-Reply-To: <20200414013849.GA886648@rfd.leadboat.com>
References: <20200406063649.GA3738151@rfd.leadboat.com>
<20200414013849.GA886648@rfd.leadboat.com>
Noah Misch <noah@leadboat.com> writes:
> This seems to have made the following race condition easier to hit:
> https://www.postgresql.org/message-id/flat/20200206074552.GB3326097%40rfd.leadboat.com
> https://www.postgresql.org/message-id/flat/21519.1585272409%40sss.pgh.pa.us
Yeah, I just came to the same guess in the other thread.
> While I don't think that indicates anything wrong with the fix for $SUBJECT,
> creating more buildfarm noise is itself bad. I am inclined to revert the fix
> after a week. Not immediately, in case it uncovers lower-probability bugs.
> I'd then re-commit it after one of those threads fixes the other bug. Would
> anyone like to argue for a revert earlier, later, or not at all?
I don't think you should revert. Those failures are (just) often enough
to be annoying but I do not think that a proper fix is very far away.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, noah@leadboat.com
Subject: Re: 001_rep_changes.pl stalls
In-Reply-To: <8807.1586828716@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox