From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_publication repetitious code
Date: Fri, 20 Dec 2019 15:54:05 -0500
Message-ID: <8839.1576875245@sss.pgh.pa.us> (raw)
In-Reply-To: <20191220201017.GA17292@alvherre.pgsql>
References: <20191220201017.GA17292@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> This very small patch removes some duplicated code in pg_publication.
Seems like the extra test on missing_oid is unnecessary:
+ oid = get_publication_oid(pubname, missing_ok);
+ if (!OidIsValid(oid) && missing_ok)
+ return NULL;
As coded, it's get_publication_oid's job to deal with that.
Otherwise +1
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_publication repetitious code
In-Reply-To: <8839.1576875245@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox