pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrey V. Lepikhov <a.lepikhov@postgrespro.ru>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Defer selection of asynchronous subplans until the executor initialization stage
Date: Mon, 30 Aug 2021 13:36:38 +0500
Message-ID: <8891e9b4-040f-6d71-fa63-3069046dfb3d@postgrespro.ru> (raw)
In-Reply-To: <CAPmGK15AshMEtgUqs3yZfD5mzW87wyn=_uAXbBeRLG0nod7vHA@mail.gmail.com>
References: <CAPmGK14igABfEruPPh1X=9KnjY=LquRHQij48oATSo1vWr7yOg@mail.gmail.com>
	<CAPmGK15xtFk2gb9-2b24mFtYBVWoGkmCPFPkM9RHpKVXGLk=sw@mail.gmail.com>
	<CAPmGK178d9-+aFgYorOY4n0pZmZ55WpQ7i1JcCagovYzAh+ueg@mail.gmail.com>
	<20210331.101137.148208859959175708.horikyota.ntt@gmail.com>
	<CAPmGK17T9Swy2FHZk4AVVKNzRxVnd96PX-18DSC2jeDXWNiBoQ@mail.gmail.com>
	<CAPmGK1637W30Wx3MnrReewhafn6F_0J76mrJGoFXFnpPq4QfvA@mail.gmail.com>
	<CAPmGK17O6fMfX84wWfypLWAO4NvD4fgDhm--oyzZ97YP+TxckA@mail.gmail.com>
	<c9388cb7-8cfc-bc92-0d6a-b519e6099cb6@postgrespro.ru>
	<CAPmGK17JTeGJtKrW_xeRtbXaPBBEQy3+AcOdqcrM0fnHGmJVsw@mail.gmail.com>
	<52d944ea-7d41-1d16-01b7-8d1edf5ea972@postgrespro.ru>
	<CAPmGK14DF1=_B6zvqfh1rx1dWHLOTJgVkfr3g50MmcBQyHEjKw@mail.gmail.com>
	<659c37a8-3e71-0ff2-394c-f04428c76f08@postgrespro.ru>
	<CALNJ-vTf+5pPgvz_t0cF0+KR=Ly36bGkAA4zBJsnSdrXDtE=oQ@mail.gmail.com>
	<edb1331c-e861-0c53-9fdb-f7ca7dfd884d@postgrespro.ru>
	<CAPmGK15AshMEtgUqs3yZfD5mzW87wyn=_uAXbBeRLG0nod7vHA@mail.gmail.com>

On 8/23/21 2:18 PM, Etsuro Fujita wrote:
> To just execute what was planned at execution time, I think we should
> return to the patch in [1].  The patch was created for Horiguchi-san’s
> async-execution patch, so I modified it to work with HEAD, and added a
> simplified version of your test cases.  Please find attached a patch.
> [1] https://www.postgresql.org/message-id/7fe10f95-ac6c-c81d-a9d3-227493eb9055@postgrespro.ru
I agree, this way is more safe. I tried to search for another approach, 
because here isn't general solution: for each plan node we should 
implement support of asynchronous behaviour.
But for practical use, for small set of nodes, it will work good. I 
haven't any objections for this patch.

-- 
regards,
Andrey Lepikhov
Postgres Professional





view thread (33+ messages)  latest in thread

Message-ID: <8891e9b4-040f-6d71-fa63-3069046dfb3d@postgrespro.ru>
Permalink:  ../8891e9b4-040f-6d71-fa63-3069046dfb3d@postgrespro.ru/
Also on:    postgresql.org/message-id/8891e9b4-040f-6d71-fa63-3069046dfb3d@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.lepikhov@postgrespro.ru, etsuro.fujita@gmail.com, zyu@yugabyte.com, horikyota.ntt@gmail.com, pryzby@telsasoft.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Defer selection of asynchronous subplans until the executor initialization stage
  In-Reply-To: <8891e9b4-040f-6d71-fa63-3069046dfb3d@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox